[Response Ops][Rules] Version Mute All Rule API #195572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcger
changed the title
jcger
force-pushed
the
issue-195181-rule_mute_all-api-versioning
branch
from
e164b25
to
7855b81
Compare
jcger
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
cnasikas
approved these changes
Oct 9, 2024
| async function muteAllWithOCC(context: RulesClientContext, { id }: { id: string }) { | ||
| async function muteAllWithOCC(context: RulesClientContext, params: MuteAllRuleParams) { | ||
| try { | ||
| muteAllRuleParamsSchema.validate(params); |
There was a problem hiding this comment.
Could you please add a unit test for this new change?
adcoelho
reviewed
Oct 9, 2024
| @@ -36,7 +31,7 @@ export const muteAllRuleRoute = ( | |||
| }, | |||
| validate: { | |||
| request: { | |||
| params: paramSchema, | |||
| params: muteAllRuleRequestParamsSchemaV1, | |||
| }, | |||
| response: { | |||
There was a problem hiding this comment.
Previously, when we did this versioning we ended up also updating the documentation. I don't know if we will do another passing but I noticed 403 is missing from the response. Maybe you could update that here? 🙏
There was a problem hiding this comment.
Maybe 400 and 404 also. I'm thinking of this PR.
There was a problem hiding this comment.
If I'm not mistaken, there is an extra issue to do it afterwards (which should be also be ready for next ff) #195182. Are we talking about the same?
There was a problem hiding this comment.
ah, I didn't realize there was a separate issue. Nevermind then!
adcoelho
approved these changes
Oct 10, 2024
…_mute_all-api-versioning
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11327378257 |
💚 Build Succeeded
Metrics [docs]
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2024
## Summary
`POST /api/alerting/rule/{id}/_mute_all` in
elastic#195181
(cherry picked from commit f787b85)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2024
) # Backport This will backport the following commits from `main` to `8.x`: - [[Response Ops][Rules] Version Mute All Rule API (#195572)](#195572) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julian Gernun","email":"17549662+jcger@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-14T12:18:42Z","message":"[Response Ops][Rules] Version Mute All Rule API (#195572)\n\n## Summary\r\n\r\n`POST /api/alerting/rule/{id}/_mute_all` in\r\nhttps://github.com//issues/195181","sha":"f787b852b23139fbc8e9926263d827ded4a1f451","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Response Ops][Rules] Version Mute All Rule API","number":195572,"url":"https://github.com/elastic/kibana/pull/195572","mergeCommit":{"message":"[Response Ops][Rules] Version Mute All Rule API (#195572)\n\n## Summary\r\n\r\n`POST /api/alerting/rule/{id}/_mute_all` in\r\nhttps://github.com//issues/195181","sha":"f787b852b23139fbc8e9926263d827ded4a1f451"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195572","number":195572,"mergeCommit":{"message":"[Response Ops][Rules] Version Mute All Rule API (#195572)\n\n## Summary\r\n\r\n`POST /api/alerting/rule/{id}/_mute_all` in\r\nhttps://github.com//issues/195181","sha":"f787b852b23139fbc8e9926263d827ded4a1f451"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julian Gernun <17549662+jcger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/alerting/rule/{id}/_mute_allin #195181