[ResponseOps][Rules] Version enable rule route #188645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
adcoelho
changed the title
js-jankisalvi
approved these changes
Jul 19, 2024
|
@js-jankisalvi i will I only learned how to do the oas changes after reviewing your PR and when I did that I had already finished versioning this :D |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
cc @adcoelho |
umbopepato
reviewed
Jul 22, 2024
| test('throws an error if API params do not match the schema', async () => { | ||
| await expect( | ||
| // @ts-ignore: this is what we are testing | ||
| async () => await rulesClient.enable({ id: 1 }) |
There was a problem hiding this comment.
nit: async/await could likely be omitted here
cnasikas
approved these changes
Jul 22, 2024
JiaweiWu
reviewed
Jul 22, 2024
| try { | ||
| await rulesClient.enable({ id }); | ||
| await rulesClient.enable(params); |
There was a problem hiding this comment.
let's follow the pattern and rename this rulesClient.enableRule so enable.ts -> enable_rule.ts
nikitaindik
approved these changes
Jul 24, 2024
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @adcoelho |
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Parent Issue: #187572
Versions the
POST /rule/{id}/_enableendpoint.Checklist