-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Improves the authoring of the query and charts #186875
Merged
Merged
Changes from 15 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
373270a
[ES|QL] Display ESQL grid of results and make the flyout resizable
stratoula da2ebf7
Merge with main and resolve conflicts
stratoula 84ec51a
some of the review comments
stratoula b3b5b64
Display a badge of values
stratoula 88fa89e
Make the header sticky
stratoula 98981f0
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine c9edb85
Merge branch 'main' into esql-inline-editing-grid
stratoula f1ae181
Open in Discover link in progress
stratoula d6fac74
Add Discover link
stratoula 92fc6dc
Internationalization
stratoula 89cb3e9
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 8c5a287
Merge branch 'main' into esql-inline-editing-grid
stratoula 6dcd334
Merge with main and resolve conflicts
stratoula e23ccd6
Adds unit tests
stratoula 9ed274b
Open Discover link in new tab
stratoula d452b31
Merge branch 'main' into esql-inline-editing-grid
stratoula 8ff2e6b
Fix typo
stratoula 1e874dc
Adds abortController
stratoula 9353484
Nit picks
stratoula 40e282b
Usde promise all
stratoula e5dc627
Address Andrea's comments
stratoula 5ddbcf3
Merge branch 'main' into esql-inline-editing-grid
stratoula 73fde7c
Fix FT
stratoula 4506321
Add min width
stratoula e4d050f
Revert
stratoula 9a49502
Add min size
stratoula e5f0fdc
Add constants
stratoula b64dc30
Move to another component
stratoula 34a6b3d
add useCallback
stratoula 63d5a5c
Make the icon blue
stratoula File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,6 +56,7 @@ | |
"embeddable", | ||
"fieldFormats", | ||
"charts", | ||
"esqlDataGrid", | ||
"esql", | ||
], | ||
"extraPublicDirs": [ | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this constant is used here and then again in line 212. Could we export it to the variable? The one above too:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure e5f0fdc