Add missing type defaults to RouteDependencies #182078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delanni
added
release_note:skip
sabarasaba
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Thanks for patching this up @delanni! Changes lgtm, but we need to set the config to true in all these cases as its meant to be disabled by config only (for serverless) and enabled by default.
...ins/index_management/server/routes/api/component_templates/register_privileges_route.test.ts
Outdated
Show resolved
Hide resolved
...ins/index_management/server/routes/api/component_templates/register_privileges_route.test.ts
Outdated
Show resolved
Hide resolved
...plugins/index_management/server/routes/api/enrich_policies/register_privileges_route.test.ts
Outdated
Show resolved
Hide resolved
...plugins/index_management/server/routes/api/enrich_policies/register_privileges_route.test.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/index_management/server/test/helpers/route_dependencies.ts
Outdated
Show resolved
Hide resolved
Use `true` as default Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 3, 2024
## Summary Typescript was temporarily out, so some type issues snuck in. This PR attempts to fix it, by adding missed field `enableTogglingDataRetention` on type `RouteDependencies` --------- Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Typescript was temporarily out, so some type issues snuck in.
This PR attempts to fix it, by adding missed field
enableTogglingDataRetentionon typeRouteDependencies