You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to refactor this PR to include @eokoneyo's general modal component
Lens needs to have Export with all three report type options - to avoid circular dependencies move the Lens CSV stuff into the reporting plugin vs having it in Lens
The reason will be displayed to describe this comment to others. Learn more.
@rshen91: Thanks for making some of the requested changes from my previous review. I'll go ahead and approve now to unblock you so this can be merged before feature freeze. Would you and @kevinsweet be willing to consider/address my remaining unresolved comments from that previous review in a separate issue? If so, let me know and I'll make one. Otherwise, if further discussion is needed regarding those comments, I'd be happy to put a Zoom session on the calendar. Thanks!
Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.
Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors #179206 to have each export type be registered in Reporting and then passed into the share plugin.
This PR is focused on the redesign in terms of the export modals. Test refactoring will be done in a separate PR.
Partially closes https://github.com/elastic/kibana-team/issues/753
[Discover] Unsaved work error on CSV reports for read-only user #151523 to keep in mind for the redesign
Failed tests will be covered in this PR #180406
TO TEST
Mark
share.new_version.enabled: true
in your kibana.dev.ymlChecklist