-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[serverless] add sorting #179901
[serverless] add sorting #179901
Conversation
Update mappings file to load field data. Update snapshots
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested locally with the current and the new ES serverless image and tests passed ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, reviewed the code and this looks how I would have done it
@tsullivan hey thanks for that message Tim! My boss and I worked on that together, but I still wasn't sure! You rock! |
## Summary This PR reenables the serverless Discover CSV tests. ### Details * The tests were failing for a new serverless ES image due to a change in default shards * The tests have been actually fixed in #179901 * Due to the way how the ES pipeline picks up Kibana changes for their verification, it took a while for this fix to take effect (actually needed to wait for the next daily scheduled run) * In the mean time, the test appeared to still be failing, so it was skipped entirely, see #180010 * With the ES serverless promotion now done, the skipped (and already fixed) test suite can be reenabled Closes #180010
Summary
Add sorting via api calls.
Update mappings file to load field data.
Update snapshots
Was failing