[serverless] add sorting #179901
Merged
[serverless] add sorting #179901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayneseymour
added
release_note:skip
Update mappings file to load field data. Update snapshots
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
pheyos
approved these changes
Apr 3, 2024
tsullivan
approved these changes
Apr 3, 2024
@tsullivan hey thanks for that message Tim! My boss and I worked on that together, but I still wasn't sure! You rock! |
pheyos
added a commit
that referenced
this pull request
Apr 5, 2024
## Summary This PR reenables the serverless Discover CSV tests. ### Details * The tests were failing for a new serverless ES image due to a change in default shards * The tests have been actually fixed in #179901 * Due to the way how the ES pipeline picks up Kibana changes for their verification, it took a while for this fix to take effect (actually needed to wait for the next daily scheduled run) * In the mean time, the test appeared to still be failing, so it was skipped entirely, see #180010 * With the ES serverless promotion now done, the skipped (and already fixed) test suite can be reenabled Closes #180010
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add sorting via api calls.
Update mappings file to load field data.
Update snapshots
Was failing