Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Share modal redesign refactor FTRs #179694

Closed
wants to merge 99 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
99 commits
Select commit Hold shift + click to select a range
d3a728b
initial commit
rshen91 Feb 22, 2024
ea7ebab
working link preview
rshen91 Feb 22, 2024
e450c70
link
rshen91 Feb 22, 2024
850cc41
tsconfig
rshen91 Feb 22, 2024
fd9e622
tsconfig
rshen91 Feb 22, 2024
700e6a4
copy link on click
rshen91 Feb 22, 2024
0158da8
wip
rshen91 Feb 29, 2024
a51d6c1
working on embed modal hooks
rshen91 Mar 4, 2024
1988c49
fix embed behavior in url
rshen91 Mar 4, 2024
2f3aaec
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Mar 4, 2024
7c54bbe
design chx
rshen91 Mar 4, 2024
02b5eb9
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Mar 4, 2024
9134ea9
fix order of tabs to match figma
rshen91 Mar 5, 2024
656bd50
short urls when click copy link
rshen91 Mar 6, 2024
0c2ec06
add package to i18n
rshen91 Mar 6, 2024
504d34f
add padding right to code block
rshen91 Mar 6, 2024
730f080
fix
rshen91 Mar 6, 2024
33a3b52
wip adapt eyos work to pr
rshen91 Mar 8, 2024
ab933c5
wip refactor to use tabbedModal
rshen91 Mar 11, 2024
a4c6b67
wip
rshen91 Mar 11, 2024
9c5a774
wip for collab
rshen91 Mar 12, 2024
4ff4dcd
rework implementation for v2 share
eokoneyo Mar 19, 2024
e4865e8
fix issue with switching state within tabbed modal
eokoneyo Mar 20, 2024
bf4e6a4
integrate link and embed modal into modal to receive correct value on…
eokoneyo Mar 20, 2024
ca21906
visual styling for share modal
eokoneyo Mar 20, 2024
0bde2f5
test1
rshen91 Mar 21, 2024
7ef4cd4
test2 wip
rshen91 Mar 21, 2024
569149c
working
rshen91 Mar 22, 2024
7aa8f43
Merge remote-tracking branch 'upstream/main' into test-reporting-moda…
rshen91 Mar 22, 2024
b14eaf8
got lens exports to work - pdf layout needs attention
rshen91 Mar 22, 2024
fe63217
fix lens reports
rshen91 Mar 22, 2024
8e087a9
Merge remote-tracking branch 'upstream/main' into test-reporting-moda…
rshen91 Mar 25, 2024
4a3b887
add licensing to kibana.jsonc for lens
rshen91 Mar 25, 2024
e65e3d2
Merge remote-tracking branch 'upstream/main' into test-reporting-moda…
rshen91 Mar 25, 2024
9e68156
some cleaning
rshen91 Mar 25, 2024
80c393a
Merge branch 'main' into test-reporting-modal-eyo
rshen91 Mar 25, 2024
0a0e541
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Mar 25, 2024
853cb54
fix buttons fordashboard
rshen91 Mar 25, 2024
7a18154
Merge remote-tracking branch 'origin/test-reporting-modal-eyo' into t…
rshen91 Mar 25, 2024
83bb65a
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Mar 25, 2024
269e20e
Merge remote-tracking branch 'upstream/main' into test-reporting-moda…
rshen91 Mar 26, 2024
b728380
Merge remote-tracking branch 'origin/test-reporting-modal-eyo' into t…
rshen91 Mar 26, 2024
3eb21bc
i18n updates
rshen91 Mar 26, 2024
2093d26
Merge branch 'main' into test-reporting-modal-eyo
rshen91 Mar 26, 2024
cd68a9b
fix some i18n but still issues with buttons not being string literals
rshen91 Mar 26, 2024
1a1d1af
Merge remote-tracking branch 'origin/test-reporting-modal-eyo' into t…
rshen91 Mar 26, 2024
ab16686
Merge remote-tracking branch 'upstream/main' into test-reporting-moda…
rshen91 Mar 26, 2024
d365a13
remove old share modal component package
rshen91 Mar 26, 2024
e98ef9a
wip refactor reporting in lens
rshen91 Mar 27, 2024
54dfbb1
fix lens licensing for rendering csv only when not gold
rshen91 Mar 27, 2024
d6f1554
Merge remote-tracking branch 'upstream/main' into test-reporting-moda…
rshen91 Mar 27, 2024
ffa2dee
design changes and more lens work
rshen91 Mar 27, 2024
17cdbe1
Merge remote-tracking branch 'upstream/main' into test-reporting-moda…
rshen91 Mar 27, 2024
4d3bc58
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Mar 27, 2024
110f063
fix lens rendering of image-export-modal
rshen91 Mar 27, 2024
a813ee4
Merge remote-tracking branch 'origin/test-reporting-modal-eyo' into t…
rshen91 Mar 27, 2024
cc27642
lens working
rshen91 Mar 27, 2024
3da70f8
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Mar 27, 2024
f2d05ea
fix circ dep
rshen91 Mar 27, 2024
e7927af
[CI] Auto-commit changed files from 'node scripts/lint_packages --fix'
kibanamachine Mar 27, 2024
1b7fa3f
fix imports
rshen91 Mar 27, 2024
4984ade
Merge remote-tracking branch 'origin/test-reporting-modal-eyo' into t…
rshen91 Mar 27, 2024
014b8ca
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Mar 27, 2024
6c8615c
design fixes
rshen91 Mar 27, 2024
f240814
lint change
rshen91 Mar 27, 2024
0e3d4d7
Merge branch 'main' into test-reporting-modal-eyo
rshen91 Mar 27, 2024
553ca08
add jest config file
rshen91 Mar 27, 2024
2475cdc
fix
rshen91 Mar 27, 2024
91b99f8
styling change
rshen91 Mar 28, 2024
9d3b482
Merge remote-tracking branch 'upstream/main' into test-reporting-moda…
rshen91 Mar 28, 2024
31428d8
disable csv if not saved
rshen91 Mar 28, 2024
ebe2b53
Merge remote-tracking branch 'upstream/main' into test-reporting-moda…
rshen91 Mar 28, 2024
b8688e7
refactored tabbed_modal
rshen91 Mar 28, 2024
96c5193
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Mar 28, 2024
4fab0f5
Merge branch 'main' into test-reporting-modal-eyo
rshen91 Mar 28, 2024
19f904b
clean up types
rshen91 Mar 28, 2024
49f4d55
Merge remote-tracking branch 'upstream/main' into test-reporting-moda…
rshen91 Mar 28, 2024
a50db5c
delete files not related to this pr
rshen91 Mar 28, 2024
8ebf6af
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Mar 28, 2024
f08d494
remove download csv from lens to avoid bundle size and put in share
rshen91 Mar 29, 2024
de84c0a
cleanup
rshen91 Mar 29, 2024
5076c0f
Merge branch 'main' into test-reporting-modal-eyo
rshen91 Mar 29, 2024
b00b380
Merge remote-tracking branch 'upstream/main' into test-reporting-moda…
rshen91 Mar 29, 2024
5f7ecdb
Merge remote-tracking branch 'origin/test-reporting-modal-eyo' into t…
rshen91 Mar 29, 2024
6d18726
inital test commit
rshen91 Mar 29, 2024
6d8c330
reflect new modal in the yml
rshen91 Mar 29, 2024
07bb722
begin rewriting tests
rshen91 Mar 29, 2024
6b53ae9
refactor
rshen91 Mar 29, 2024
606830e
revert canvas pdf reporting test changes
rshen91 Mar 29, 2024
d51ec98
put download csv back to avoid circ dependency with the data plugin
rshen91 Mar 29, 2024
8c855ed
Merge branch 'main' into share-modal-redesign-tests-ftrs
rshen91 Mar 29, 2024
52d2612
more tests
rshen91 Mar 29, 2024
7d1f5ca
Merge remote-tracking branch 'origin/share-modal-redesign-tests-ftrs'…
rshen91 Mar 29, 2024
f2ca5ea
Merge remote-tracking branch 'upstream/main' into share-modal-redesig…
rshen91 Mar 29, 2024
1ef237b
Merge remote-tracking branch 'upstream/main' into share-modal-redesig…
rshen91 Apr 1, 2024
cd34f52
update
rshen91 Apr 1, 2024
1f2ad7d
old share panel removal
rshen91 Apr 1, 2024
582f7ab
refactor weird test
rshen91 Apr 1, 2024
0a8f81e
Merge remote-tracking branch 'upstream/main' into share-modal-redesig…
rshen91 Apr 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,7 @@ packages/kbn-repo-path @elastic/kibana-operations
packages/kbn-repo-source-classifier @elastic/kibana-operations
packages/kbn-repo-source-classifier-cli @elastic/kibana-operations
packages/kbn-reporting/common @elastic/appex-sharedux
packages/kbn-reporting/get_csv_panel_actions @elastic/appex-sharedux
x-pack/examples/reporting_example @elastic/appex-sharedux
packages/kbn-reporting/export_types/csv @elastic/appex-sharedux
packages/kbn-reporting/export_types/csv_common @elastic/appex-sharedux
Expand Down Expand Up @@ -794,6 +795,7 @@ packages/shared-ux/router/mocks @elastic/appex-sharedux
packages/shared-ux/router/types @elastic/appex-sharedux
packages/shared-ux/storybook/config @elastic/appex-sharedux
packages/shared-ux/storybook/mock @elastic/appex-sharedux
packages/shared-ux/modal/tabbed @elastic/appex-sharedux
packages/kbn-shared-ux-utility @elastic/appex-sharedux
x-pack/plugins/observability_solution/slo @elastic/obs-ux-management-team
x-pack/packages/kbn-slo-schema @elastic/obs-ux-management-team
Expand Down
1 change: 1 addition & 0 deletions config/kibana.yml
Original file line number Diff line number Diff line change
Expand Up @@ -181,3 +181,4 @@
# Maximum number of documents loaded by each shard to generate autocomplete suggestions.
# This value must be a whole number greater than zero. Defaults to 100_000
#unifiedSearch.autocomplete.valueSuggestions.terminateAfter: 100000
share.new_version.enabled: true
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,7 @@
"@kbn/repo-info": "link:packages/kbn-repo-info",
"@kbn/repo-packages": "link:packages/kbn-repo-packages",
"@kbn/reporting-common": "link:packages/kbn-reporting/common",
"@kbn/reporting-csv-share-panel": "link:packages/kbn-reporting/get_csv_panel_actions",
"@kbn/reporting-example-plugin": "link:x-pack/examples/reporting_example",
"@kbn/reporting-export-types-csv": "link:packages/kbn-reporting/export_types/csv",
"@kbn/reporting-export-types-csv-common": "link:packages/kbn-reporting/export_types/csv_common",
Expand Down Expand Up @@ -796,6 +797,7 @@
"@kbn/shared-ux-router-types": "link:packages/shared-ux/router/types",
"@kbn/shared-ux-storybook-config": "link:packages/shared-ux/storybook/config",
"@kbn/shared-ux-storybook-mock": "link:packages/shared-ux/storybook/mock",
"@kbn/shared-ux-tabbed-modal": "link:packages/shared-ux/modal/tabbed",
"@kbn/shared-ux-utility": "link:packages/kbn-shared-ux-utility",
"@kbn/slo-plugin": "link:x-pack/plugins/observability_solution/slo",
"@kbn/slo-schema": "link:x-pack/packages/kbn-slo-schema",
Expand Down
1 change: 1 addition & 0 deletions packages/kbn-generate-csv/src/generate_csv.ts
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ export class CsvGenerator {

public async generateData(): Promise<TaskRunResult> {
const logger = this.logger;

const [settings, searchSource] = await Promise.all([
getExportSettings(
this.clients.uiSettings,
Expand Down
4 changes: 2 additions & 2 deletions packages/kbn-optimizer/limits.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ pageLoadAssetSize:
kibanaUsageCollection: 16463
kibanaUtils: 79713
kubernetesSecurity: 77234
lens: 57135
lens: 96692
licenseManagement: 41817
licensing: 29004
links: 44490
Expand Down Expand Up @@ -115,7 +115,7 @@ pageLoadAssetSize:
presentationUtil: 58834
profiling: 36694
remoteClusters: 51327
reporting: 57003
reporting: 78653
rollup: 97204
runtimeFields: 41752
savedObjects: 108518
Expand Down
9 changes: 9 additions & 0 deletions packages/kbn-reporting/get_csv_panel_actions/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0 and the Server Side Public License, v 1; you may not use this file except
* in compliance with, at your election, the Elastic License 2.0 or the Server
* Side Public License, v 1.
*/

export { ReportingCsvPanelAction } from './panel_actions/get_csv_panel_action';
13 changes: 13 additions & 0 deletions packages/kbn-reporting/get_csv_panel_actions/jest.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0 and the Server Side Public License, v 1; you may not use this file except
* in compliance with, at your election, the Elastic License 2.0 or the Server
* Side Public License, v 1.
*/

module.exports = {
preset: '@kbn/test',
rootDir: '../../..',
roots: ['<rootDir>/packages/kbn-reporting/get_csv_panel_actions'],
};
5 changes: 5 additions & 0 deletions packages/kbn-reporting/get_csv_panel_actions/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"type": "shared-browser",
"id": "@kbn/reporting-csv-share-panel",
"owner": "@elastic/appex-sharedux"
}
6 changes: 6 additions & 0 deletions packages/kbn-reporting/get_csv_panel_actions/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"name": "@kbn/reporting-csv-share-panel",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ import { dataViewMock } from '@kbn/discover-utils/src/__mocks__';
import { LicenseCheckState } from '@kbn/licensing-plugin/public';
import { licensingMock } from '@kbn/licensing-plugin/public/mocks';
import type { SavedSearch } from '@kbn/saved-search-plugin/public';
import { ReportingAPIClient } from '../..';
import type { ClientConfigType } from '../../types';
import { ReportingAPIClient } from '@kbn/reporting-public';
import type { ClientConfigType } from '@kbn/reporting-public/types';
import {
ActionContext,
type PanelActionDependencies,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ import type { UiActionsActionDefinition as ActionDefinition } from '@kbn/ui-acti
import { IncompatibleActionError } from '@kbn/ui-actions-plugin/public';

import { CSV_REPORTING_ACTION, JobAppParamsCSV } from '@kbn/reporting-export-types-csv-common';
import type { ClientConfigType } from '../../types';
import { checkLicense } from '../../license_check';
import type { ReportingAPIClient } from '../../reporting_api_client';
import type { ClientConfigType } from '@kbn/reporting-public/types';
import { checkLicense } from '@kbn/reporting-public/license_check';
import type { ReportingAPIClient } from '@kbn/reporting-public/reporting_api_client';
import { getI18nStrings } from './strings';

function isSavedSearchEmbeddable(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import React from 'react';
import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n-react';
import type { ReportingAPIClient } from '../../reporting_api_client';
import type { ReportingAPIClient } from '@kbn/reporting-public/reporting_api_client';

interface I18nStrings {
displayName: string;
Expand Down
31 changes: 31 additions & 0 deletions packages/kbn-reporting/get_csv_panel_actions/tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{
"extends": "../../../tsconfig.base.json",
"compilerOptions": {
"outDir": "target/types",
"types": [
"jest",
"node"
]
},
"include": [
"**/*.ts", "**/*.tsx"
],
"exclude": [
"target/**/*"
],
"kbn_references": [
"@kbn/core",
"@kbn/data-plugin",
"@kbn/i18n",
"@kbn/reporting-export-types-csv-common",
"@kbn/licensing-plugin",
"@kbn/i18n-react",
"@kbn/discover-utils",
"@kbn/saved-search-plugin",
"@kbn/discover-plugin",
"@kbn/embeddable-plugin",
"@kbn/ui-actions-plugin",
"@kbn/react-kibana-mount",
"@kbn/reporting-public",
]
}
2 changes: 1 addition & 1 deletion packages/kbn-reporting/public/share/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
export { getSharedComponents } from './shared';
export { reportingScreenshotShareProvider } from './share_context_menu/register_pdf_png_reporting';
export { reportingCsvShareProvider } from './share_context_menu/register_csv_reporting';
export { ReportingCsvPanelAction } from './panel_actions/get_csv_panel_action';
export type { ReportingPublicComponents } from './shared/get_shared_components';
export type { JobParamsProviderOptions } from './share_context_menu';
Loading