Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Share Modal Redesign] Reporting modals with licensing using link/embed tabbed modal component #179206

Closed
wants to merge 97 commits into from
Closed

[Share Modal Redesign] Reporting modals with licensing using link/embed tabbed modal component #179206

wants to merge 97 commits into from

Commits on Mar 20, 2024

  1. initial commit

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    d3a728b View commit details
    Browse the repository at this point in the history

  2. working link preview

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ea7ebab View commit details
    Browse the repository at this point in the history

  3. link

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    e450c70 View commit details
    Browse the repository at this point in the history

  4. tsconfig

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    850cc41 View commit details
    Browse the repository at this point in the history

  5. tsconfig

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    fd9e622 View commit details
    Browse the repository at this point in the history

  6. copy link on click

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    700e6a4 View commit details
    Browse the repository at this point in the history

  7. wip

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    0158da8 View commit details
    Browse the repository at this point in the history

  8. working on embed modal hooks

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    a51d6c1 View commit details
    Browse the repository at this point in the history

  9. fix embed behavior in url

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    1988c49 View commit details
    Browse the repository at this point in the history

  10. [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --… 

    …fix'
    @kibanamachine @rshen91
    kibanamachine authored and rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    2f3aaec View commit details
    Browse the repository at this point in the history

  11. design chx

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    7c54bbe View commit details
    Browse the repository at this point in the history

  12. [CI] Auto-commit changed files from 'node scripts/generate codeowners'

    @kibanamachine @rshen91
    kibanamachine authored and rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    02b5eb9 View commit details
    Browse the repository at this point in the history

  13. fix order of tabs to match figma

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    9134ea9 View commit details
    Browse the repository at this point in the history

  14. short urls when click copy link

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    656bd50 View commit details
    Browse the repository at this point in the history

  15. add package to i18n

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    0c2ec06 View commit details
    Browse the repository at this point in the history

  16. add padding right to code block

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    504d34f View commit details
    Browse the repository at this point in the history

  17. fix

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    730f080 View commit details
    Browse the repository at this point in the history

  18. wip adapt eyos work to pr

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    33a3b52 View commit details
    Browse the repository at this point in the history

  19. wip refactor to use tabbedModal

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ab933c5 View commit details
    Browse the repository at this point in the history

  20. wip

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    a4c6b67 View commit details
    Browse the repository at this point in the history

  21. wip for collab

    @rshen91
    rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    9c5a774 View commit details
    Browse the repository at this point in the history

  22. rework implementation for v2 share

    @eokoneyo @rshen91
    eokoneyo authored and rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4ff4dcd View commit details
    Browse the repository at this point in the history

  23. fix issue with switching state within tabbed modal

    @eokoneyo @rshen91
    eokoneyo authored and rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    e4865e8 View commit details
    Browse the repository at this point in the history

  24. integrate link and embed modal into modal to receive correct value on… 

    … copy attempt
    @eokoneyo @rshen91
    eokoneyo authored and rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    bf4e6a4 View commit details
    Browse the repository at this point in the history

  25. visual styling for share modal

    @eokoneyo @rshen91
    eokoneyo authored and rshen91 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ca21906 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. test1

    @rshen91
    rshen91 committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    0bde2f5 View commit details
    Browse the repository at this point in the history

  2. test2 wip

    @rshen91
    rshen91 committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    7ef4cd4 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. working

    @rshen91
    rshen91 committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    569149c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    7aa8f43 View commit details
    Browse the repository at this point in the history

  3. got lens exports to work - pdf layout needs attention

    @rshen91
    rshen91 committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    b14eaf8 View commit details
    Browse the repository at this point in the history

  4. fix lens reports

    @rshen91
    rshen91 committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    fe63217 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    8e087a9 View commit details
    Browse the repository at this point in the history

  2. add licensing to kibana.jsonc for lens

    @rshen91
    rshen91 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    4a3b887 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e65e3d2 View commit details
    Browse the repository at this point in the history

  4. some cleaning

    @rshen91
    rshen91 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    9e68156 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into test-reporting-modal-eyo

    @rshen91
    rshen91 authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    80c393a View commit details
    Browse the repository at this point in the history

  6. [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --… 

    …fix'
    @kibanamachine
    kibanamachine committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    0a0e541 View commit details
    Browse the repository at this point in the history

  7. fix buttons fordashboard

    @rshen91
    rshen91 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    853cb54 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/test-reporting-modal-eyo' into t… 

    …est-reporting-modal-eyo
    @rshen91
    rshen91 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    7a18154 View commit details
    Browse the repository at this point in the history

  9. [CI] Auto-commit changed files from 'node scripts/generate codeowners'

    @kibanamachine
    kibanamachine committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    83bb65a View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    269e20e View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/test-reporting-modal-eyo' into t… 

    …est-reporting-modal-eyo
    @rshen91
    rshen91 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    b728380 View commit details
    Browse the repository at this point in the history

  3. i18n updates

    @rshen91
    rshen91 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3eb21bc View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into test-reporting-modal-eyo

    @rshen91
    rshen91 authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    2093d26 View commit details
    Browse the repository at this point in the history

  5. fix some i18n but still issues with buttons not being string literals

    @rshen91
    rshen91 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    cd68a9b View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/test-reporting-modal-eyo' into t… 

    …est-reporting-modal-eyo
    @rshen91
    rshen91 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    1a1d1af View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ab16686 View commit details
    Browse the repository at this point in the history

  8. remove old share modal component package

    @rshen91
    rshen91 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    d365a13 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. wip refactor reporting in lens

    @rshen91
    rshen91 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    e98ef9a View commit details
    Browse the repository at this point in the history

  2. fix lens licensing for rendering csv only when not gold

    @rshen91
    rshen91 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    54dfbb1 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d6f1554 View commit details
    Browse the repository at this point in the history

  4. design changes and more lens work

    @rshen91
    rshen91 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    ffa2dee View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    17cdbe1 View commit details
    Browse the repository at this point in the history

  6. [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --… 

    …fix'
    @kibanamachine
    kibanamachine committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    4d3bc58 View commit details
    Browse the repository at this point in the history

  7. fix lens rendering of image-export-modal

    @rshen91
    rshen91 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    110f063 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/test-reporting-modal-eyo' into t… 

    …est-reporting-modal-eyo
    @rshen91
    rshen91 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    a813ee4 View commit details
    Browse the repository at this point in the history

  9. lens working

    @rshen91
    rshen91 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    cc27642 View commit details
    Browse the repository at this point in the history

  10. [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --… 

    …fix'
    @kibanamachine
    kibanamachine committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    3da70f8 View commit details
    Browse the repository at this point in the history

  11. fix circ dep

    @rshen91
    rshen91 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f2d05ea View commit details
    Browse the repository at this point in the history

  12. [CI] Auto-commit changed files from 'node scripts/lint_packages --fix'

    @kibanamachine
    kibanamachine committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    e7927af View commit details
    Browse the repository at this point in the history

  13. fix imports

    @rshen91
    rshen91 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1b7fa3f View commit details
    Browse the repository at this point in the history

  14. Merge remote-tracking branch 'origin/test-reporting-modal-eyo' into t… 

    …est-reporting-modal-eyo
    @rshen91
    rshen91 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    4984ade View commit details
    Browse the repository at this point in the history

  15. [CI] Auto-commit changed files from 'node scripts/generate codeowners'

    @kibanamachine
    kibanamachine committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    014b8ca View commit details
    Browse the repository at this point in the history

  16. design fixes

    @rshen91
    rshen91 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    6c8615c View commit details
    Browse the repository at this point in the history

  17. lint change

    @rshen91
    rshen91 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f240814 View commit details
    Browse the repository at this point in the history

  18. Merge branch 'main' into test-reporting-modal-eyo

    @rshen91
    rshen91 authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    0e3d4d7 View commit details
    Browse the repository at this point in the history

  19. add jest config file

    @rshen91
    rshen91 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    553ca08 View commit details
    Browse the repository at this point in the history

  20. fix

    @rshen91
    rshen91 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2475cdc View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. styling change

    @rshen91
    rshen91 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    91b99f8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    9d3b482 View commit details
    Browse the repository at this point in the history

  3. disable csv if not saved

    @rshen91
    rshen91 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    31428d8 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    ebe2b53 View commit details
    Browse the repository at this point in the history

  5. refactored tabbed_modal

    @rshen91
    rshen91 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    b8688e7 View commit details
    Browse the repository at this point in the history

  6. [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --… 

    …fix'
    @kibanamachine
    kibanamachine committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    96c5193 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into test-reporting-modal-eyo

    @rshen91
    rshen91 authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    4fab0f5 View commit details
    Browse the repository at this point in the history

  8. clean up types

    @rshen91
    rshen91 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    19f904b View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    49f4d55 View commit details
    Browse the repository at this point in the history

  10. delete files not related to this pr

    @rshen91
    rshen91 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    a50db5c View commit details
    Browse the repository at this point in the history

  11. [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --… 

    …fix'
    @kibanamachine
    kibanamachine committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    8ebf6af View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. remove download csv from lens to avoid bundle size and put in share

    @rshen91
    rshen91 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    f08d494 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @rshen91
    rshen91 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    de84c0a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into test-reporting-modal-eyo

    @rshen91
    rshen91 authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    5076c0f View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    b00b380 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/test-reporting-modal-eyo' into t… 

    …est-reporting-modal-eyo
    @rshen91
    rshen91 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    5f7ecdb View commit details
    Browse the repository at this point in the history

  6. put download csv back to avoid circ dependency with the data plugin

    @rshen91
    rshen91 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    0f4403a View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    22f5e9b View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. refactor new register method for new share redesign

    @rshen91
    rshen91 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    2d0e9c8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    315487f View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d1be71b View commit details
    Browse the repository at this point in the history

  4. refactor the registry

    @rshen91
    rshen91 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    44b8393 View commit details
    Browse the repository at this point in the history

  5. refactor to send to share plugin wip

    @rshen91
    rshen91 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    a6fab4c View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. got the export tab modal rendering

    @rshen91
    rshen91 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    3c736bf View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    4ad06bd View commit details
    Browse the repository at this point in the history

  3. wip reports dont work but modals set up

    @rshen91
    rshen91 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    24cad86 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    2f7b903 View commit details
    Browse the repository at this point in the history

  5. wip reporting is working except for console errors and lens csv

    @rshen91
    rshen91 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    61d5405 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into test-reporting-moda… 

    …l-eyo
    @rshen91
    rshen91 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d60cc52 View commit details
    Browse the repository at this point in the history