Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SentinelOne] Fix Agent status on Timeline Alert details #176210

Merged
merged 3 commits into from
Feb 10, 2024
Merged

[SentinelOne] Fix Agent status on Timeline Alert details #176210

merged 3 commits into from
Feb 10, 2024

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Feb 5, 2024 •
edited by kibanamachine
Loading

Summary

Closes #174235

Zrzut ekranu 2024-02-5 o 11 54 15 Zrzut ekranu 2024-02-5 o 11 53 53

@patrykkopycinski
Copy link
Contributor Author

/ci

@patrykkopycinski patrykkopycinski marked this pull request as ready for review February 5, 2024 15:51
@patrykkopycinski patrykkopycinski requested a review from a team as a code owner February 5, 2024 15:51
@patrykkopycinski patrykkopycinski self-assigned this Feb 5, 2024
@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.13.0 v8.12.2 labels Feb 5, 2024
@patrykkopycinski patrykkopycinski enabled auto-merge (squash) February 8, 2024 13:33
PhilippeOberti
PhilippeOberti approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Threat Hunting Investigations team

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.4MB 11.4MB +79.0B
Unknown metric groups

References to deprecated APIs

id before after diff
securitySolution 520 522 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

@patrykkopycinski patrykkopycinski merged commit 361398c into elastic:main Feb 10, 2024
35 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.12 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 176210

Questions ?

Please refer to the Backport tool documentation

@ashokaditya ashokaditya mentioned this pull request Feb 12, 2024
Merged
@ashokaditya
Copy link
Member

💚 All backports created successfully

Status Branch Result
✅ 8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

ashokaditya pushed a commit to ashokaditya/kibana that referenced this pull request Feb 12, 2024
@patrykkopycinski
[SentinelOne] Fix Agent status on Timeline Alert details (elastic#176210
2467a33 
)

## Summary

Fixes elastic#174235

<img width="1906" alt="Zrzut ekranu 2024-02-5 o 11 54 15"
src="https://github.com/elastic/kibana/assets/5188868/5f40dc64-c0fc-4fbf-b4b9-d8ee6e75c890">

<img width="1910" alt="Zrzut ekranu 2024-02-5 o 11 53 53"
src="https://github.com/elastic/kibana/assets/5188868/425efd0b-242e-4bb7-b034-13b34c1dde44">

Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
(cherry picked from commit 361398c)

# Conflicts:
#	x-pack/plugins/security_solution/public/timelines/components/timeline/body/renderers/formatted_field.tsx
@patrykkopycinski patrykkopycinski deleted the fix/s1-alert-status-timeline-alert-details branch February 12, 2024 08:39
ashokaditya added a commit that referenced this pull request Feb 12, 2024
@ashokaditya @patrykkopycinski
[8.12] [SentinelOne] Fix Agent status on Timeline Alert details (#176210
3bc8190 
) (#176663)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[SentinelOne] Fix Agent status on Timeline Alert details
(#176210)](#176210)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Patryk
Kopyciński","email":"contact@patrykkopycinski.com"},"sourceCommit":{"committedDate":"2024-02-10T12:28:32Z","message":"[SentinelOne]
Fix Agent status on Timeline Alert details (#176210)\n\n## Summary\r\n
\r\nFixes #174235 \r\n\r\n<img
width=\"1906\" alt=\"Zrzut ekranu 2024-02-5 o 11 54
15\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/5f40dc64-c0fc-4fbf-b4b9-d8ee6e75c890\">\r\n\r\n<img
width=\"1910\" alt=\"Zrzut ekranu 2024-02-5 o 11 53
53\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/425efd0b-242e-4bb7-b034-13b34c1dde44\">\r\n\r\nCo-authored-by:
Ash
<1849116+ashokaditya@users.noreply.github.com>","sha":"361398cd9d8af89210dfb8c70dd0631e22ec5beb","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","OLM
Sprint","v8.13.0","v8.12.2"],"number":176210,"url":"https://github.com/elastic/kibana/pull/176210","mergeCommit":{"message":"[SentinelOne]
Fix Agent status on Timeline Alert details (#176210)\n\n## Summary\r\n
\r\nFixes #174235 \r\n\r\n<img
width=\"1906\" alt=\"Zrzut ekranu 2024-02-5 o 11 54
15\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/5f40dc64-c0fc-4fbf-b4b9-d8ee6e75c890\">\r\n\r\n<img
width=\"1910\" alt=\"Zrzut ekranu 2024-02-5 o 11 53
53\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/425efd0b-242e-4bb7-b034-13b34c1dde44\">\r\n\r\nCo-authored-by:
Ash
<1849116+ashokaditya@users.noreply.github.com>","sha":"361398cd9d8af89210dfb8c70dd0631e22ec5beb"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176210","number":176210,"mergeCommit":{"message":"[SentinelOne]
Fix Agent status on Timeline Alert details (#176210)\n\n## Summary\r\n
\r\nFixes #174235 \r\n\r\n<img
width=\"1906\" alt=\"Zrzut ekranu 2024-02-5 o 11 54
15\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/5f40dc64-c0fc-4fbf-b4b9-d8ee6e75c890\">\r\n\r\n<img
width=\"1910\" alt=\"Zrzut ekranu 2024-02-5 o 11 53
53\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/425efd0b-242e-4bb7-b034-13b34c1dde44\">\r\n\r\nCo-authored-by:
Ash
<1849116+ashokaditya@users.noreply.github.com>","sha":"361398cd9d8af89210dfb8c70dd0631e22ec5beb"}},{"branch":"8.12","label":"v8.12.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@patrykkopycinski @ashokaditya @CoenWarmer
[SentinelOne] Fix Agent status on Timeline Alert details (elastic#176210
80261bd 
)

## Summary
 
Fixes elastic#174235 

<img width="1906" alt="Zrzut ekranu 2024-02-5 o 11 54 15"
src="https://github.com/elastic/kibana/assets/5188868/5f40dc64-c0fc-4fbf-b4b9-d8ee6e75c890">

<img width="1910" alt="Zrzut ekranu 2024-02-5 o 11 53 53"
src="https://github.com/elastic/kibana/assets/5188868/425efd0b-242e-4bb7-b034-13b34c1dde44">

Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@patrykkopycinski @ashokaditya @CoenWarmer
[SentinelOne] Fix Agent status on Timeline Alert details (elastic#176210
3cf2565 
)

## Summary
 
Fixes elastic#174235 

<img width="1906" alt="Zrzut ekranu 2024-02-5 o 11 54 15"
src="https://github.com/elastic/kibana/assets/5188868/5f40dc64-c0fc-4fbf-b4b9-d8ee6e75c890">

<img width="1910" alt="Zrzut ekranu 2024-02-5 o 11 53 53"
src="https://github.com/elastic/kibana/assets/5188868/425efd0b-242e-4bb7-b034-13b34c1dde44">

Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@patrykkopycinski @ashokaditya @fkanout
[SentinelOne] Fix Agent status on Timeline Alert details (elastic#176210
c42070c 
)

## Summary
 
Fixes elastic#174235 

<img width="1906" alt="Zrzut ekranu 2024-02-5 o 11 54 15"
src="https://github.com/elastic/kibana/assets/5188868/5f40dc64-c0fc-4fbf-b4b9-d8ee6e75c890">

<img width="1910" alt="Zrzut ekranu 2024-02-5 o 11 53 53"
src="https://github.com/elastic/kibana/assets/5188868/425efd0b-242e-4bb7-b034-13b34c1dde44">

Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
@ashokaditya ashokaditya mentioned this pull request Mar 11, 2024
Closed
@ashokaditya ashokaditya mentioned this pull request Apr 18, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokaditya ashokaditya ashokaditya approved these changes

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
bug Fixes for quality problems that affect the customer experience OLM Sprint release_note:skip Skip the PR/issue when compiling release notes v8.12.2 v8.13.0
Projects
None yet
Milestone
No milestone
5 participants
@patrykkopycinski @kibana-ci @kibanamachine @ashokaditya @PhilippeOberti