-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs Explorer] Change the default link for "Discover" in the serverless nav #173420
Merged
weltenwort
merged 10 commits into
elastic:main
from
weltenwort:obs-change-default-discover-tab
Jan 3, 2024
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fb1459e
Change the default link for "Discover" in the serverless nav
weltenwort aff3514
Merge remote-tracking branch 'upstream/main' into obs-change-default-…
weltenwort 932e1dc
Fix serverless navigation tests
weltenwort fa58c8b
Attempt to fix the Discover breadcrumbs
weltenwort 8268407
Merge remote-tracking branch 'upstream/main' into obs-change-default-…
weltenwort 45d5b90
Merge remote-tracking branch 'upstream/main' into obs-change-default-…
weltenwort ba7c7be
Skip Discover side nav test on serverless-oblt
weltenwort eeeadc9
Merge remote-tracking branch 'upstream/main' into obs-change-default-…
weltenwort 2598f0a
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine 500e0c1
Remove superfluous `sideNavStatus` entries
weltenwort File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want ever to mark this link as active?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The menu hierarchy here is:
Logs Explorer
, which is never active and hides its breadcrumb, but needed so the Logs Explorer is the default tabDiscover
, which is needed soDiscover
shows up in the breadcrumbs and the entry is active when in DiscoverLogs Explorer
, which is needed so the breadcrumbs areDiscover
/Logs Explorer
and the entry is also active when in the Logs ExplorerIt's the only way I found to get the serverless nav and breadcrumbs to behave that way. If you know of any other approach to achieve the same thing I'd gladly adopt it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked and indeed the way multiple active node paths (here you have 2 pointing to the
observability-log-explorer
link) are declared forces you to do this. I'll open a PR to fix it in the serverless nav so you don't need to hack it here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be great. Would you prefer us to wait for your change or shall I align with it in a follow-up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry just reading now. All good in opened my PR after you merged 👍
#174184