Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maps] remove Maps data view telemetry #152124

Merged
merged 10 commits into from
Feb 28, 2023
Merged

[maps] remove Maps data view telemetry #152124

merged 10 commits into from
Feb 28, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Feb 24, 2023

Fixes #152121

Removes data view telemetry collection

@nreese
Copy link
Contributor Author

nreese commented Feb 24, 2023

@elasticmachine merge upstream

@nreese nreese marked this pull request as ready for review February 24, 2023 22:37
@nreese nreese requested review from a team as code owners February 24, 2023 22:37
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:Maps v8.8.0 labels Feb 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor Author

nreese commented Feb 28, 2023

@elasticmachine merge upstream

nickpeihl
nickpeihl approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! using the cluster_stats to get geo field counts is 💯 !

code review and tested telemetry collection locally

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 428 430 +2

Total ESLint disabled count

id before after diff
securitySolution 506 508 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 391220a into elastic:main Feb 28, 2023
sloanelybutsurely pushed a commit to sloanelybutsurely/kibana that referenced this pull request Mar 8, 2023
@nreese @kibanamachine
[maps] remove Maps data view telemetry (elastic#152124)
ea43d3e 
Fixes elastic#152121

Removes data view telemetry collection

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@jsanz jsanz mentioned this pull request Mar 9, 2023
Closed
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@nreese @kibanamachine @bmorelli25
[maps] remove Maps data view telemetry (elastic#152124)
14e83f8 
Fixes elastic#152121

Removes data view telemetry collection

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
nkhristinin pushed a commit that referenced this pull request Mar 22, 2023
@nreese @kibanamachine @nkhristinin
[maps] remove Maps data view telemetry (#152124)
78ef973 
Fixes #152121

Removes data view telemetry collection

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

@Bamieh Bamieh Bamieh approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Maps release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[maps] remove Maps data view telemetry
6 participants
@nreese @elasticmachine @kibana-ci @nickpeihl @Bamieh @kibanamachine