Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Add automatic = insertion on equal comparison typing when in Formula #143286

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Oct 13, 2022

Summary

Follow up from #142325

This PR adds the automatic insertion of a second = when the user types within a comparison block:

eq_autocomplete

As shown in the gif there's no conflict with other named arguments/parameters and it won't work for fields (as they are not valid in that context).

Because the injected char is now equal to the trigger one, there's the potential of an infinite loop, which is prevented by looking at the previous char (try to remove the previous char part from the code to see the issue):

eq_autocomplete_edge

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v8.6.0 labels Oct 13, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB +80.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 marked this pull request as ready for review October 13, 2022 15:34
@dej611 dej611 requested a review from a team as a code owner October 13, 2022 15:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@drewdaemon
Copy link
Contributor

NBD, but is there an easy way to hide this empty suggestions list?

Screen.Recording.2022-10-13.at.11.45.07.AM.mov

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@dej611
Copy link
Contributor Author

dej611 commented Oct 13, 2022

NBD, but is there an easy way to hide this empty suggestions list?

Screen.Recording.2022-10-13.at.11.45.07.AM.mov

Not sure, but that's a good idea. Can you log an issue about it? I'll check it later

@dej611 dej611 merged commit bdeedea into elastic:main Oct 13, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 13, 2022
@dej611 dej611 deleted the fix/autosuggest-eq branch October 13, 2022 17:28
@drewdaemon
Copy link
Contributor

drewdaemon commented Oct 13, 2022

@dej611

Not sure, but that's a good idea. Can you log an issue about it? I'll check it later

#143326 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants