[Enterprise Search] Provide UX feedback for rechecking connector #138432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
added
v8.4.0
v8.5.0
Team:EnterpriseSearch
release_note:skip
byronhulcher
approved these changes
Aug 9, 2022
sphilipse
force-pushed
the
ent-search-2407-recheck-button
branch
from
b61d31a
to
aa0db86
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 9, 2022
…stic#138432) (cherry picked from commit 59b403c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
cauemarcondes
pushed a commit
to cauemarcondes/kibana
that referenced
this pull request
Aug 9, 2022
…stic#138432) (elastic#138444) (cherry picked from commit 59b403c) Co-authored-by: Sander Philipse <94373878+sphilipse@users.noreply.github.com>
leemthompo
reviewed
Aug 10, 2022
| i18n.translate( | ||
| 'xpack.enterpriseSearch.content.searchIndex.index.recheckSuccess.message', | ||
| { | ||
| defaultMessage: 'Successfully rechecked your connector', |
There was a problem hiding this comment.
I think "successfully" is redundant here.
Suggestion: Your connector has been rechecked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a toast message and spinner as visual feedback to the user that we actually rechecked their connector:
