Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Osquery] Refactor telemetry to use EBT #138221

Merged
merged 4 commits into from
Aug 9, 2022
Merged

[Osquery] Refactor telemetry to use EBT #138221

merged 4 commits into from
Aug 9, 2022

Conversation

patrykkopycinski
Copy link
Contributor

Summary

Implements #137963

@patrykkopycinski patrykkopycinski self-assigned this Aug 6, 2022
@patrykkopycinski patrykkopycinski added release_note:skip Skip the PR/issue when compiling release notes Team:Asset Management Security Asset Management Team Feature:Osquery Security Solution Osquery feature auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 v8.5.0 labels Aug 6, 2022
@patrykkopycinski patrykkopycinski marked this pull request as ready for review August 6, 2022 19:38
@patrykkopycinski patrykkopycinski requested review from a team as code owners August 6, 2022 19:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-asset-management (Team:Asset Management)

tomsonpl
tomsonpl approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asset Management LGTM

@patrykkopycinski patrykkopycinski requested review from afharo and removed request for a team August 8, 2022 16:06
afharo
afharo approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this so quickly!! LGTM!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 4 3 -1

ESLint disabled line counts

id before after diff
osquery 99 98 -1

Total ESLint disabled count

id before after diff
osquery 103 101 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

@patrykkopycinski patrykkopycinski merged commit 3de9eda into elastic:main Aug 9, 2022
@patrykkopycinski patrykkopycinski deleted the chore/osquery-ebt branch August 9, 2022 15:50
kibanamachine pushed a commit that referenced this pull request Aug 9, 2022
@patrykkopycinski
[Osquery] Refactor telemetry to use EBT (#138221)
b16100e 
(cherry picked from commit 3de9eda)
@kibanamachine kibanamachine mentioned this pull request Aug 9, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

cauemarcondes pushed a commit to cauemarcondes/kibana that referenced this pull request Aug 9, 2022
@kibanamachine @patrykkopycinski
[Osquery] Refactor telemetry to use EBT (elastic#138221) (elastic#138424
9d3cf38 
)

(cherry picked from commit 3de9eda)

Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
@afharo afharo mentioned this pull request Sep 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

@tomsonpl tomsonpl tomsonpl approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Osquery Security Solution Osquery feature release_note:skip Skip the PR/issue when compiling release notes Team:Asset Management Security Asset Management Team v8.4.0 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@patrykkopycinski @elasticmachine @kibana-ci @kibanamachine @afharo @tomsonpl