Commits on Aug 2, 2022

1. Fixes Spaces Menu Keyboard and Screen Reader Navigation (elastic#134454) …

   * Refactor of spaces pop-over using EuiSelectable.
   
   * Updated to use Eui type instead of interface.
   
   * Reorganization of code, began to add EuiSelectableOnChangeEvent usage.
   
   * Repathed import after rebase
   
   * Integrates the EuiSelectableOnChangeEvent argument to intercept keyboard and mouse event details (shift, ctrl, middle click).
   
   * Resolves missing property error in nav popover test.
   
   * Handles reintroduction of translated strings into empty and no match messages of the Spaces selectable.
   
   * Refactor of spaces_popover_list to use EuiSelectable, resolves keyboard navigation.
   
   * Updated tests for spaces popover list and created more comprehensive tests for nav control popover.
   Eliminated tab selection of popover panel itself. Tested screen reader extensively with Chrome on Mac.
   Note: Safari screen reader and tabbing behavior is not consistent and differs significantly from Chrome.
   
   * Adjuted focus behavior in popover. Rebased to use EUI 60.1.2
   
   * Fixed typo in roles spaces popover list. Keyboard navigation with options (shift, ctrl, etc.) is not yet working - event argument in selectable onChange is null for keyboard events.
   
   * Updated comments.
   
   * Fixes issue with keyboard operation of manage spaces button of spaces_menu. Fixes naming of translated string resources in spaces_popover_list.
   
   * Fixes name of existing string reference in spaces_menu.
   
   * Fixes CSS selector calls in spaces functional test.
   
   * Fixes space selection in functional tests.
   
   * Fixes popover close issue on Manage spaces button click. Implements check for re-selecting active space. Implements popover close when opening a space in a new window.
   
   * Updated jest snapshot for spaces nav test.
   
   * Fixes ML functional tests to accommodate new behavior when selecting already active space.
   
   * Added active space highlight feedback. Removed state from spaces menu class.
   
   * Rebased, added check mark for active space, resolved activeOption keyboard nav break from EUI update
   
   * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'
   
   * Fixes initial active space highlight which was caused by initial empty spaces state in nav_control_popover and loading render logic.
   Removes isLoading from spaces_menu - no longer necessary, SpacesDescription is now used during loading.
   
   * Added debug output of actual URL in route expects.
   
   * Added loading message to spaces navigation.
   
   * Updated jest snapshot.
   
   * Addressed flaky test behavior related to space menu nav. Implemented review feedback suggestions.
   
   * Adds sleep to functional test UI interactions.
   
   * Replaced use of any with ExclusiveUnion for search props of EuiSelectable.
   Resolved flaky test for spaces nav.
   
   Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
   (cherry picked from commit 31c2c0f)

   

   jeramysoucy committed Aug 2, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 39cc4c4
   • Browse repository at this point

   Copy the full SHA

   39cc4c4 View commit details

   Browse the repository at this point in the history