[Lens] fix suggestion panel styling #135622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
Team:Visualizations
mbondyra
force-pushed
the
lens/fix_suggestion_styling
branch
from
0afc149
to
157903d
Compare
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
mbondyra
added
the
release_note:skip
mbondyra
force-pushed
the
lens/fix_suggestion_styling
branch
from
157903d
to
6d6b835
Compare
|
Is this taking these changes into account? elastic/eui#6010 There was a general bug in EUI in the way styles are handled for panels, maybe it fixes the problem already on EUI without the need to change the Kibana side structure |
|
If not let's keep this PR open until #135373 is merged - then we can check whether the problem still occurs |
|
👌🏼 makes sense @flash1293, thanks for the comment. I'll return the state of this PR to draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes regression for suggestion panel after introducing emotion changes to eui. When EuiPanel has an
onClickaction, it becomes a button and inherits some stylings that don't fit Lens suggestion panel. That's why I wrapped EuiPanel with button instead.Before and after:
