Bumping EUI to v41.2.2 #119205

1Copenut · 2021-11-19T17:23:16Z

Summary

eui@41.0.0 ⏩ eui@41.2.2

`41.2.0`

Added aria-label and aria-labelledby props to EuiComboBox (#5360)
Updated EuiDatePicker to use EuiPopover, EuiFocusTrap, and EuiScreenReaderOnly (#5339)

Bug fixes

Fixed an EuiDataGrid row height bug for grids that set a default lineCount and also used rowHeights to set row-specific lineCounts (#5376)
Fixed EuiComboBox from allowing keyboard actions when isDisabled (#5373)
Fixed an accessibility issue where EuiSuperSelect was not creating accessible labels for its listbox (#5364)
Fixed an accessibility issue where EuiColorPalettePicker was not creating an accessible label for its button (#5364)
Fixed EuiDatePicker being constrained to its parent container by using React portal (#5339)

`41.1.0`

Added layout and footer props to EuiEmptyPrompt (#5275)
Updated EuiEmptyPrompt to extend EuiPanelProps (#5275)
Add data-icon-type to EuiIcon <svg> for easier debugging of iconType #5366)

Bug fixes

Fixed an EuiDataGrid race condition where grid rows had incorrect heights if loaded in before CSS (#5284)
Fixed an accessibility issue where EuiDataGrid cells weren't owned by role=row elements (#5285)
Fixed EuiErrorBoundary overflow scrolling by wrapping contents in EuiCodeBlock (#5359)
Fixed analyzeEvent icon to be horizontally centered #5365)

1Copenut · 2021-11-19T19:49:52Z

@elasticmachine merge upstream

Merging from upstream.

cee-chen · 2021-11-25T04:21:50Z

@elasticmachine merge upstream

1Copenut · 2021-12-01T20:40:01Z

@elasticmachine merge upstream

1Copenut · 2021-12-01T21:54:55Z

@elasticmachine merge upstream

watson

Besides the yarn.lock nit the changes to Kibana Platform Security LGTM 👍 I checked it out locally, ran Kibana and compared the screens with the same screens in main and couldn't see any differences.

watson · 2021-12-02T09:59:07Z

yarn.lock

@@ -29915,6 +29916,19 @@ yargs@^17.0.1:
    y18n "^5.0.5"
    yargs-parser "^20.2.2"

+yargs@^17.2.1:


We should consolidate this with the yargs@^17.0.1 dependency just above to avoid having too many versions of the same acceptable version range installed

Dosant

App services src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap lgtm

1Copenut · 2021-12-02T14:34:04Z

@elasticmachine merge upstream

thompsongl · 2021-12-03T21:47:28Z

elastic/eui#5441 will resolve the failing tests. We'll update this PR after making a backport release with the changes.

FrankHassanabad · 2021-12-07T15:57:51Z

x-pack/plugins/security_solution/cypress/integration/timelines/row_renderers.spec.ts

@@ -98,7 +98,7 @@ describe('Row renderers', () => {
          expect(
            elementsOverlap($googleLinkTooltip, $signatureTooltip),
            'tooltips do not overlap'
-          ).to.equal(false);
+          ).to.equal(true);


Are the tool tips overlapping now with that change? Seems like you had to switch from false to true?

I ran the cypress tests in your fork locally and this test fails with to.equal(true) as it should. The test was created to make sure that the two tooltips on this link don't overlap:

Changing it back to to.equal(false) fixes the tests for me locally. Does the test break on the CI with to.equal(false)?

I've been testing it locally (Cypress is awesome, and the docs are super helpful) with the same results you're getting. I'll change it back and update the three others that are failing. I'm also seeing those failures locally with a browser. I'll try them locally headless and hopefully get this finished up.

kibana-ci · 2021-12-08T19:31:24Z

💛 Build succeeded, but was flaky

Test Failures

[job] [logs] Security Solution Tests / Detection rules, machine learning Creates and activates a new ml rule

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.0MB	3.0MB	+1.0B
`ml`	3.5MB	3.5MB	+1.0B
total			+2.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	275.6KB	275.7KB	+122.0B
`kbnUiSharedDeps-css`	587.4KB	590.8KB	+3.4KB
`kbnUiSharedDeps-npmDll`	5.0MB	5.1MB	+59.1KB
total			+62.6KB

History

💔 Build #11883 failed ca01f37
💔 Build #11777 failed 7ce55fb
💚 Build #11592 succeeded 9b02356
💔 Build #10665 failed e78af33
💔 Build #10539 failed 65290a9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @1Copenut

kibanamachine · 2021-12-08T20:24:12Z

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 119205

* Bumping EUI to v41.2.0 * Updating translations for EUI Super Select. * Bumping to v41.2.1 for an EUI fix. * Updating ten Jest snapshots * Removing reference to packaged datepicker now in EUI. * Final removal of packaged Datepicker reference. * Updating snapshots and datagrid test defaults. * Fixing last functional test for data grid * Reverting data source to upstream example for one test. * Adding a fix for _data_table.ts test. * Adding a fix for _data_table)notimeindex_filters.ts * Bumping to 41.2.2 patch fix * Removing unneeded test code and updating comment * Bumping to 41.2.3 for bug fix. * Adding a missed file. * Adjusting test for tooltip overlap assertion. * Updating two tests in Security Solution Platform. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

1Copenut added 2 commits November 19, 2021 10:45

Bumping EUI to v41.2.0

6388c3b

Updating translations for EUI Super Select.

709c15f

1Copenut added release_note:skip Skip the PR/issue when compiling release notes EUI auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Nov 19, 2021

1Copenut self-assigned this Nov 19, 2021

kibanamachine and others added 4 commits November 19, 2021 14:49

Merge branch 'main' into eui/41-2-0

9a1aae2

Merge remote-tracking branch 'upstream/main' into eui/41-2-0

eda0a98

Bumping to v41.2.1 for an EUI fix.

ac7ae09

Merge branch 'eui/41-2-0' of github.com:1Copenut/kibana into eui/41-2-0

212c4e8

Merging from upstream.

1Copenut changed the title ~~Bumping EUI to v41.2.0~~ Bumping EUI to v41.2.1 Nov 19, 2021

1Copenut added 9 commits November 22, 2021 09:58

Updating ten Jest snapshots

25c0177

Removing reference to packaged datepicker now in EUI.

514e472

Final removal of packaged Datepicker reference.

68aa202

Updating snapshots and datagrid test defaults.

10a75b1

Fixing last functional test for data grid

12f31a9

Reverting data source to upstream example for one test.

de5dd89

Adding a fix for _data_table.ts test.

bd3ff25

Adding a fix for _data_table)notimeindex_filters.ts

2768738

Merge remote-tracking branch 'upstream/main' into eui/41-2-0

7a08801

cee-chen mentioned this pull request Nov 24, 2021

Exclude mocks and Cypress specs from eui.d.ts elastic/eui#5412

Merged

1 task

Bumping to 41.2.2 patch fix

285ed1b

1Copenut changed the title ~~Bumping EUI to v41.2.1~~ Bumping EUI to v41.2.2 Nov 24, 2021

Merge branch 'main' into eui/41-2-0

7b9913b

1Copenut marked this pull request as ready for review November 29, 2021 14:19

1Copenut requested review from a team as code owners November 29, 2021 14:19

Merge branch 'main' into eui/41-2-0

6844780

Merge branch 'main' into eui/41-2-0

65ba080

Merge branch 'main' into eui/41-2-0

65290a9

watson approved these changes Dec 2, 2021

View reviewed changes

Dosant approved these changes Dec 2, 2021

View reviewed changes

Merge branch 'main' into eui/41-2-0

e78af33

ashokaditya approved these changes Dec 3, 2021

View reviewed changes

1Copenut added 4 commits December 6, 2021 14:50

Merge branch 'main' into eui/41-2-0

2ffe3ab

Bumping to 41.2.3 for bug fix.

0b3547c

Adding a missed file.

3738b14

Adjusting test for tooltip overlap assertion.

9b02356

1Copenut requested a review from a team as a code owner December 6, 2021 23:21

Merge branch 'main' into eui/41-2-0

7ce55fb

FrankHassanabad reviewed Dec 7, 2021

View reviewed changes

1Copenut and others added 4 commits December 7, 2021 12:15

Merging upstream main branch.

182e3b0

Resolving merge conflict in lens_page.ts.

ca01f37

Updating two tests in Security Solution Platform.

de8c73e

Merge branch 'main' into eui/41-2-0

93d86b8

thompsongl merged commit 34dd896 into elastic:main Dec 8, 2021

kibanamachine added the backport:skip This commit does not require backporting label Dec 8, 2021

1Copenut removed the auto-backport Deprecated - use backport:version if exact versions are needed label Dec 8, 2021

1Copenut deleted the eui/41-2-0 branch December 8, 2021 20:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bumping EUI to v41.2.2 #119205

Bumping EUI to v41.2.2 #119205

1Copenut commented Nov 19, 2021 •

edited

Loading

1Copenut commented Nov 19, 2021

cee-chen commented Nov 25, 2021

1Copenut commented Dec 1, 2021

1Copenut commented Dec 1, 2021

watson left a comment

watson Dec 2, 2021

Dosant left a comment

1Copenut commented Dec 2, 2021

thompsongl commented Dec 3, 2021

FrankHassanabad Dec 7, 2021

janmonschke Dec 8, 2021

1Copenut Dec 8, 2021

kibana-ci commented Dec 8, 2021

kibanamachine commented Dec 8, 2021

Bumping EUI to v41.2.2 #119205

Bumping EUI to v41.2.2 #119205

Conversation

1Copenut commented Nov 19, 2021 • edited Loading

Summary

41.2.0

41.1.0

1Copenut commented Nov 19, 2021

cee-chen commented Nov 25, 2021

1Copenut commented Dec 1, 2021

1Copenut commented Dec 1, 2021

watson left a comment

Choose a reason for hiding this comment

watson Dec 2, 2021

Choose a reason for hiding this comment

Dosant left a comment

Choose a reason for hiding this comment

1Copenut commented Dec 2, 2021

thompsongl commented Dec 3, 2021

FrankHassanabad Dec 7, 2021

Choose a reason for hiding this comment

janmonschke Dec 8, 2021

Choose a reason for hiding this comment

1Copenut Dec 8, 2021

Choose a reason for hiding this comment

kibana-ci commented Dec 8, 2021

💛 Build succeeded, but was flaky

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

kibanamachine commented Dec 8, 2021

💔 Backport failed

1Copenut commented Nov 19, 2021 •

edited

Loading

`41.2.0`

`41.1.0`