Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.15] Upgrade EUI to v37.1.3 #111199

Merged
merged 5 commits into from
Sep 7, 2021
Merged

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Sep 3, 2021

Summary

eui@37.1.2eui@37.1.3

This is a backport of some bug fixes meant for 7.15, see elastic/eui#5083 for more details

  • Updated a couple snapshots
  • Removed an affected localization from the ja-JP and ch-CN files so they get reprocessed

37.1.3

Note: this release is a backport containing changes originally made in 37.4.0 and 37.6.1

Bug fixes

  • Fixed instance of EuiScreenReader text being exposed in EuiDataGrid sorting menu (#5084)
  • Fixed screen reader text from displaying in some EuiDataGrid cell popovers (#5087)
  • Fixed EuiDataGrid cell actions not unmounting from the DOM after mouse interaction (#5120)
  • Optimized EuiDataGrid cell interactions' performance (#5136)

@chandlerprall chandlerprall changed the base branch from master to 7.15 September 3, 2021 18:50
@chandlerprall chandlerprall changed the title Upgrade EUI to v37.1.3 [7.15] Upgrade EUI to v37.1.3 Sep 3, 2021
@chandlerprall chandlerprall added EUI release_note:skip Skip the PR/issue when compiling release notes v7.15.0 labels Sep 3, 2021
@chandlerprall chandlerprall marked this pull request as ready for review September 6, 2021 18:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@chandlerprall chandlerprall added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Sep 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 425.8KB 425.9KB +56.0B
kbnUiSharedDeps-elastic 2.6MB 2.6MB +331.0B
total +387.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@snide
Copy link
Contributor

snide commented Sep 7, 2021

These issues may be unrelated to this PR, I'm marking them just in case while I continue testing. I tested them by pointing to the Obs release cluster and making new alerts.

The height of the grid in Security is calculating incorrectly. Otherwise it rendered quite fast.

image

When clicking around in that dead area (or in pagination), I think it may have caused some sort of infinite loop. I was able to make this happen often enough where the page would get unresponsive.

image

Likely unrelated. When viewing alerts for Obs I got a dead page.

image

@chandlerprall
Copy link
Contributor Author

Merging to unblock and we can continue looking at these. Fyi - I had an unrelated session with @andrew-goldstein last week where he got that blnk obs screen.

@chandlerprall chandlerprall merged commit 73033c7 into elastic:7.15 Sep 7, 2021
@weltenwort
Copy link
Member

ℹ️ I couldn't reproduce that error on the observability alerts page with clean alerts data.

@chandlerprall chandlerprall deleted the eui-37.1.3 branch September 7, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants