Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console Autocomplete Definitions Update for 7.15 #109353

Merged

Conversation

cuff-links
Copy link
Contributor

Summary

Closes #109173

This PR will add the autocomplete suggestions for console to Kibana for 7.15.

To Test

Pull this PR and open the console in Dev Tools. Try to access the desired endpoints and check if the right data autocompletes.

@cuff-links cuff-links added Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v7.15.0 labels Aug 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@yuliacech
Copy link
Contributor

Thanks for working on this, @cuff-links!
Definitions look good to me, could you please update the ILM specs? There is a new _meta field and the frozen phase is still missing in the autocomplete.

@cuff-links
Copy link
Contributor Author

Thanks for working on this, @cuff-links!
Definitions look good to me, could you please update the ILM specs? There is a new _meta field and the frozen phase is still missing in the autocomplete.

Added. Thanks for the catch. Good eye.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cuff-links! Looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants