Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Table headers are aligned the same as cells #101875

Merged
merged 3 commits into from
Jun 15, 2021

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jun 10, 2021

Summary

Fixes #98644

Reuse the same cell alignment class for table headers.

Screenshot 2021-06-10 at 12 58 13

Screenshot 2021-06-10 at 13 01 37

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dej611 dej611 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 10, 2021
@dej611 dej611 marked this pull request as ready for review June 10, 2021 14:40
@dej611 dej611 requested a review from a team June 10, 2021 14:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB +192.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe the PR title should be updated to match release notes. I suggest Table headers are aligned the same as cells

@dej611 dej611 changed the title [Lens] Fix table headers alignment behaviour [Lens] Table headers are aligned the same as cells Jun 15, 2021
@dej611 dej611 merged commit 37728f5 into elastic:master Jun 15, 2021
@dej611 dej611 deleted the lens/fix-98644 branch June 15, 2021 08:35
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 15, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 15, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
cuff-links pushed a commit to cuff-links/kibana that referenced this pull request Jun 15, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Data Table - Text Alignment not applied to column headers
5 participants