Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect message displayed on importing Timeline Templates #101288

Merged
merged 3 commits into from
Jun 7, 2021

Conversation

machadoum
Copy link
Member

closes #100767

Summary

Context:
The import button can be used to import both timelines and timeline templates.
In theory, one imported file could have multiple timelines and timeline templates at the same time.

Solution:
Since the import endpoint only returns the total count and not the type of the imported documents.
It seems like that rewording "timeline(s)" to "item(s)" is the most straightforward fix that solves
the user problem.

Checklist

Context:
The import button can be used to import both timelines and timeline templates.
In theory, one imported file could have multiple timelines and timeline templates at the same time.

Solution:
Since the import endpoint only returns the total count and not the type of the imported documents.
It seems like that rewording "timeline(s)" to "item(s)" is the most straightforward fix that solves
the user problem.
@machadoum machadoum added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. 7.14 candidate labels Jun 3, 2021
@machadoum machadoum self-assigned this Jun 3, 2021
@machadoum machadoum requested a review from a team as a code owner June 3, 2021 15:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@machadoum
Copy link
Member Author

@elasticmachine merge upstream

@michaelolo24
Copy link
Contributor

Hey @machadoum, this makes sense generally, but I would run it by @bfishel or @monina-n

@monina-n
Copy link

monina-n commented Jun 4, 2021

looks good to me! thanks @machadoum

@machadoum
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.9MB 6.9MB -8.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit 49a355f into elastic:master Jun 7, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 7, 2021
* master: (90 commits)
  Fix UI breaks on providing long search keyword in 'Search Box' (elastic#101385)
  Adds css class to EuiDescriptionListDescription in order to break word on exception details card (elastic#101481)
  [Lens] Increase timings for drag and drop tests (elastic#101380)
  [Lens] Fix editor react error on configuration panel (elastic#101367)
  [Fleet] Move integrations to a separate app (elastic#99848)
  Fix incorrect message displayed on importing Timeline Templates (elastic#101288)
  [Cases] RBAC (elastic#95058)
  [APM] Visual improvements for new APM layout with left navigation (elastic#101360)
  [master] More precise alerts matching (elastic#99820)
  [Lens] Value in legend (elastic#101353)
  Revert "[Reporting] ILM policy for managing reporting indices (elastic#100130)" (elastic#101358)
  [Discover] Fix header row of data grid in Firefox (elastic#101374)
  Add link to advanced setting in Discover (elastic#101154)
  Url service locators (elastic#101045)
  [Timelion] Update the removal message to mention the exact version (elastic#100994)
  [Security Solution][Detection Engine] Test cases for alias failure test cases where we don't copy aliases correctly (elastic#101437)
  [Event Log] Adding `type_id` to saved object array in event log (elastic#100939)
  [Reporting] Add `location.url` info to console message logs (elastic#101427)
  [Security Solutions][Detection Engine] Fixes timestamp bugs within source indexes when the formats are not ISO8601 format (elastic#101349)
  Improve Task Manager instrumentation (elastic#99160)
  ...
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 101288 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 9, 2021
machadoum added a commit to machadoum/kibana that referenced this pull request Jun 10, 2021
…tic#101288)

Context:
The import button can be used to import both timelines and timeline templates.
In theory, one imported file could have multiple timelines and timeline templates at the same time.

Solution:
Since the import endpoint only returns the total count and not the type of the imported documents.
It seems like that rewording "timeline(s)" to "item(s)" is the most straightforward fix that solves
the user problem.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
machadoum added a commit that referenced this pull request Jun 10, 2021
) (#101881)

Context:
The import button can be used to import both timelines and timeline templates.
In theory, one imported file could have multiple timelines and timeline templates at the same time.

Solution:
Since the import endpoint only returns the total count and not the type of the imported documents.
It seems like that rewording "timeline(s)" to "item(s)" is the most straightforward fix that solves
the user problem.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Solution]Incorrect message is getting displayed on importing any Timeline Template.
6 participants