-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tagcloud] Replaces current implementation with elastic-charts #100017
[Tagcloud] Replaces current implementation with elastic-charts #100017
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
home
changes lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flash1293 I can't replicate it. Click event works for me both on the editor and on the dashboard. About the coloring, I thought about it, but I decided to follow the old implementation. I am open to discussion though. I have no strong feelings about it :D I preferred that way only because I don't want to introduce changes to our users that use the compatibility palette. |
@stratoula I will check with a clean checkout again, but it always happens for me, for really basic charts: Won't get a pointer cursor and it doesn't do anything on click |
@flash1293 this was a late addition on the es-charts so maybe you need a cleanup on the library. About the cursor pointer, thanks for reminding me of this :D @markov00 I think it will be good to change the cursor on each tag, to visualize that it is clickable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulling in the latest version made clicking work, but the cursor should be fixed.
I see what you mean about coloring - LGTM
I will solve it with css in this PR |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
…ic#100017) * WIP - Replace tagcloud with es-charts wordcloud * Cleanup and add unit tests * Fix interpreter test * Update all tagcloud snapshots * Partial fix tagcloud test * Fix some other functional tests, add migration script, update sample data * Replace getColor with getCategorixalColor * Fix functional test * Apply clickhandler event for filtering by clicking the word * Fix weight calculation * Add a unit test and fix functional * Change the cursor to pointer Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…) (#102150) * WIP - Replace tagcloud with es-charts wordcloud * Cleanup and add unit tests * Fix interpreter test * Update all tagcloud snapshots * Partial fix tagcloud test * Fix some other functional tests, add migration script, update sample data * Replace getColor with getCategorixalColor * Fix functional test * Apply clickhandler event for filtering by clicking the word * Fix weight calculation * Add a unit test and fix functional * Change the cursor to pointer Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…ic#100017) * WIP - Replace tagcloud with es-charts wordcloud * Cleanup and add unit tests * Fix interpreter test * Update all tagcloud snapshots * Partial fix tagcloud test * Fix some other functional tests, add migration script, update sample data * Replace getColor with getCategorixalColor * Fix functional test * Apply clickhandler event for filtering by clicking the word * Fix weight calculation * Add a unit test and fix functional * Change the cursor to pointer Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Closes #95539 Closes #101021 Closes #94043 Closes #93665 Closes #93664 Closes #89523 Closes #22382
Implementation of tagcloud with es-charts
Done in this PR
vis_type_tagcloud
Checklist
Delete any items that are not applicable to this PR.