Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer allow the x-elastic-product-origin header to be configurable #89803

Closed
kobelb opened this issue Jan 29, 2021 · 4 comments · Fixed by #92359
Closed

No longer allow the x-elastic-product-origin header to be configurable #89803

kobelb opened this issue Jan 29, 2021 · 4 comments · Fixed by #92359
Labels
Project:SystemIndices Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@kobelb
Copy link
Contributor

kobelb commented Jan 29, 2021

Currently, users can override the value of the x-elastic-product-origin header that Kibana specifies on all HTTP requests to Elastic. Users should no longer be able to do so starting in 8.0, as this header is critical for the proper operation of Kibana's externally managed system indices per #81536

@kobelb kobelb added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jan 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kobelb
Copy link
Contributor Author

kobelb commented Jan 29, 2021

@joshdover can we get this added to the Core team's roadmap to be implemented by 8.0?

@pgayvallet
Copy link
Contributor

So just to be sure, we are just talking about raising an error if "x-elastic-product-origin" is added to elasticsearch.requestHeadersWhitelist in the kibana config?

@kobelb
Copy link
Contributor Author

kobelb commented Feb 22, 2021

@pgayvallet we should raise an error if "x-elastic-product-origin" is added to elasticsearch.requestHeadersWhitelist or elasticsearch.customHeaders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project:SystemIndices Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants