Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps][Search Sessions] Pass down sessionId from embeddable to search calls #85449

Closed
lizozom opened this issue Dec 9, 2020 · 2 comments · Fixed by #89342
Closed

[Maps][Search Sessions] Pass down sessionId from embeddable to search calls #85449

lizozom opened this issue Dec 9, 2020 · 2 comments · Fixed by #89342
Assignees
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result Feature:Search Querying infrastructure in Kibana v7.12.0 v8.0.0

Comments

@lizozom
Copy link
Contributor

lizozom commented Dec 9, 2020

We're aiming to release the MVP of Background Sessions (BGS) in 7.12.
The MVP supports saving BGS on Discover and Dashboard.

In order for a map on a dashboard to be saved with the session, the maps embeddable needs to take in the searchSessionId and pass it down to the search API.

searchSession.fetch({
...
sessionId,
});

If this is not done before 7.12, when users try to save a search session from a dashboard with a map, the map won't be stored and restored properly.

@lizozom lizozom added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result v8.0.0 v7.12.0 labels Dec 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@Dosant Dosant changed the title [Maps][Search] Pass down sessionId from embeddable to search calls [Maps][Search Sessions] Pass down sessionId from embeddable to search calls Jan 26, 2021
@Dosant Dosant added the Feature:Search Querying infrastructure in Kibana label Jan 26, 2021
@Dosant
Copy link
Contributor

Dosant commented Jan 26, 2021

Some more details:

Search session are available under ff in master:

xpack.data_enhanced.search.sessions.enabled: true

Some prior art for reference:

Please note:

  • Functional tests for this feature. Should be useful for testing and adding maps specific tests.
  • Unfortunately, we don't have example plugins or dev docs right now.
  • This issue is only about making sure maps embeddable supports search sessions on a dashboard. Supporting search session in maps app is out of scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result Feature:Search Querying infrastructure in Kibana v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants