Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search][Dashboard] Don't create search session on "panels" change #85293

Closed
Dosant opened this issue Dec 8, 2020 · 1 comment
Closed

[Search][Dashboard] Don't create search session on "panels" change #85293

Dosant opened this issue Dec 8, 2020 · 1 comment
Assignees
@Dosant
Labels
Feature:Dashboard Dashboard related features Feature:Search Querying infrastructure in Kibana

Comments

@Dosant
Copy link
Contributor

Dosant commented Dec 8, 2020

Part of #83640

This pr change when search session is started on a dashboard. It fixed bunch of bugs, but led to re-fetching data more often then we did before.

More context: #84261 (comment)

We shouldn't trigger full refetch, for example, when a new panel was triggered.

For this we need to allow to add new searches to a session when it is already completed.

cc @lizozom @ThomThomson
@Dosant Dosant added Feature:Search Querying infrastructure in Kibana Feature:Dashboard Dashboard related features Team:AppServices labels Dec 8, 2020
@Dosant Dosant self-assigned this Dec 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@Dosant Dosant mentioned this issue Dec 8, 2020
Merged
2 tasks
@lizozom lizozom closed this as completed Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dosant Dosant

Labels
Feature:Dashboard Dashboard related features Feature:Search Querying infrastructure in Kibana
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lizozom @Dosant @elasticmachine