Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of /elasticsearch/_msearch endpoint in Index Pattern Management UI #73993

Closed
joshdover opened this issue Jul 31, 2020 · 9 comments · Fixed by #77564
Closed

Replace usage of /elasticsearch/_msearch endpoint in Index Pattern Management UI #73993

joshdover opened this issue Jul 31, 2020 · 9 comments · Fixed by #77564
Assignees
Labels
blocker Feature:Data Views Data Views code and UI - index patterns before 8.0 NeededFor:Core technical debt Improvement of the software architecture and operational architecture

Comments

@joshdover
Copy link
Contributor

In order to unblock removing legacy plugin support (#71927) we need to remove all usages of the /elasticsearch/_msearch endpoint. This can be replaced with a specific endpoint in the index_pattern_management plugin that provides only the needed functionality for the frontend.

const esResp = await http.fetch('/elasticsearch/_msearch', { method: 'POST', body });

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers added blocker Feature:Data Views Data Views code and UI - index patterns before 8.0 technical debt Improvement of the software architecture and operational architecture labels Aug 3, 2020
@lukasolson
Copy link
Member

Just an FYI this isn't the only place the endpoint is used, it's also used if you have the courier:batchSearches setting turned on. (See #54147 and #55140.)

@joshdover
Copy link
Contributor Author

@lukasolson Just saw your comment here. Are we going to need to keep this endpoint until 8.0 in order to not break that feature? Is that a feature we must keep around until 8?

If so, maybe the best course of action here is for the Platform team to migrate this endpoint out of legacy and mark it as deprecated.

@lukeelmers
Copy link
Member

Are we going to need to keep this endpoint until 8.0 in order to not break that feature? Is that a feature we must keep around until 8?

Yes, I believe the plan is to keep that setting around until 8.0

I'm currently working on an /internal/msearch endpoint which has some extra handling which would allow us to close this issue and #55139 at the same time.

@pgayvallet
Copy link
Contributor

@lukeelmers I see #75943 unfortunately did not address this issue. This is still planned for 7.10, right?

@joshdover
Copy link
Contributor Author

pinging @lukasolson since Elmers is out ⬆

@lukasolson
Copy link
Member

Yes, I believe this is still being targeted for 7.10.

@lukeelmers
Copy link
Member

I'm actively working on this now, expecting to have a PR ready soon.

@lukeelmers
Copy link
Member

PR is up: #77564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Feature:Data Views Data Views code and UI - index patterns before 8.0 NeededFor:Core technical debt Improvement of the software architecture and operational architecture
Projects
None yet
5 participants