Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Replace the uses of any introduced during the lodash 4 upgrade with proper typings #70728

Closed
weltenwort opened this issue Jul 3, 2020 · 1 comment · Fixed by #75507
Closed

[Metrics UI] Replace the uses of any introduced during the lodash 4 upgrade with proper typings #70728

weltenwort opened this issue Jul 3, 2020 · 1 comment · Fixed by #75507
Assignees
@Zacqary
Labels
chore Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@weltenwort
Copy link
Member

Summary

With the upgrade of the lodash library and its associated typings to version 4 in #69868, several any casts had to be introduced to placate the compiler.

Acceptance criteria

  • The anys introduced in the Metrics UI codebase during the lodash upgrade are replace with correct typings.
@weltenwort weltenwort added chore Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jul 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary Zacqary self-assigned this Aug 19, 2020
@Zacqary Zacqary mentioned this issue Aug 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zacqary Zacqary

Labels
chore Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Metrics UI] Replace uses of any introduced by Lodash 4 Zacqary/kibana
3 participants
@weltenwort @Zacqary @elasticmachine