Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] clearing index pattern does not clear preview layer #67618

Closed
nreese opened this issue May 28, 2020 · 2 comments
Closed

[Maps] clearing index pattern does not clear preview layer #67618

nreese opened this issue May 28, 2020 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation

Comments

@nreese
Copy link
Contributor

nreese commented May 28, 2020 •
edited
Loading

Clearing index pattern for es_search_source, es_geo_grid_source and es_pew_pew source does not clear preview layer. This is because debouncedLoad returns early when indexPatternId is not provided. When indexPatternId is provided, _onGeoFieldSelect is called which triggers onSourceConfigChange. To fix the problem, need to ensure onSourceConfigChange is triggered when indexPatternId is cleared.
@nreese nreese added bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels May 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese mentioned this issue May 28, 2020
Merged
@nreese
Copy link
Contributor Author

nreese commented Jul 15, 2020

closed in #69699. That PR remove the ability to clear index pattern

@nreese nreese closed this as completed Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nreese @elasticmachine