Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEARCH] Refactor fetchSoon and callClient to isolate msearch #61739

Closed
Tracked by #61738
lizozom opened this issue Mar 29, 2020 · 1 comment · Fixed by #63320
Closed
Tracked by #61738

[SEARCH] Refactor fetchSoon and callClient to isolate msearch #61739

lizozom opened this issue Mar 29, 2020 · 1 comment · Fixed by #63320
Assignees
Labels
Feature:Search Querying infrastructure in Kibana v7.8.0 v8.0.0

Comments

@lizozom
Copy link
Contributor

lizozom commented Mar 29, 2020

Part of #61738

This is the current search logic flow chart:

image

To simplify implementation and segregate legacy code, we'd need to refactor the flow to become"

image

The key changes here are

  • Check whether batchSearches is enabled from within SearchSource (this code is to stick around until v8)
  • Delete defaultSearchStrategy altogether
  • Move fetch, callClient and msearch to a LEGACY folder.
  • If batchSearches is disabled, call data's search service directly from SearchSource, otherwise call LEGACY logic
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants