Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Lens embeddable hardcodes the supportedTriggers #61605

Closed
timroes opened this issue Mar 27, 2020 · 1 comment · Fixed by #122348
Closed

[Lens] Lens embeddable hardcodes the supportedTriggers #61605

timroes opened this issue Mar 27, 2020 · 1 comment · Fixed by #122348
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@timroes
Copy link
Contributor

timroes commented Mar 27, 2020 •
edited by mbondyra
Loading

We currently have a hardcoded list in the supportedTriggers method in the Lens embeddable. This works fine right now, because other plugins currently can't register any own visualizations. I consider this to be a tech-debt, that we hardcode that list, since it prevents us from other plugins and solutions providing own visualizations into Lens. We should instead have the visualiation implementation let decide about what triggers it supports.

Similar issue for visualize embeddable: #61601
@timroes timroes added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Mar 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 mentioned this issue Aug 14, 2020
Closed
43 tasks
@flash1293 flash1293 mentioned this issue Dec 8, 2021
Closed
@flash1293 flash1293 mentioned this issue Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] Expose vis registration flash1293/kibana
2 participants
@timroes @elasticmachine