Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] New platform migration: Lift up ui/chrome dependency #34444

Closed
jasonrhodes opened this issue Apr 3, 2019 · 3 comments · Fixed by #41868
Closed

[APM] New platform migration: Lift up ui/chrome dependency #34444

jasonrhodes opened this issue Apr 3, 2019 · 3 comments · Fixed by #41868
Assignees
Labels
Team:APM All issues that need APM UI Team support v7.4.0

Comments

@jasonrhodes
Copy link
Member

jasonrhodes commented Apr 3, 2019

Broken-out from #32894

Remove static webpack-magic imports for ui/chrome and replace with a single import in our top-level index file.

AC:

  • import x from 'ui/chrome' should only appear once in APM, in the top-level file
  • all other uses of ui/chrome should be provided from inside our app, either by DI, context, or some other singleton approach

Known uses of ui/chrome:

  • chrome.addBasePath() in several places
  • chrome.breadcrumbs.set()
  • chrome.getInjected('apmIndexPatternTitle') in quite a few places
  • chrome.getUiSettingsClient() used for 'dateFormat:tz' in WatcherFlyout
  • chrome.navLinkExists('apm') in toggle_app_link_in_nav
  • used in our apm/public/index file:
    • chrome.helpExtension.set()
    • chrome.setRootTemplate(template)
    • chrome.disableAutoAngularUrlEncodingFix()
@jasonrhodes jasonrhodes added Team:APM All issues that need APM UI Team support [zube]: Inbox labels Apr 3, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@sorenlouv
Copy link
Member

@jasonrhodes I'm starting to look into this. I'll create the shims for the new platform, and lift up ui/chrome.

@sorenlouv
Copy link
Member

This depends on #34533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support v7.4.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants