Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dashboard panel preview experience #187864

Open
eokoneyo opened this issue Jul 9, 2024 · 5 comments
Open

Improve dashboard panel preview experience #187864

eokoneyo opened this issue Jul 9, 2024 · 5 comments
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Dashboard Usability Related to the Dashboard Usability initiative Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@eokoneyo
Copy link
Contributor

eokoneyo commented Jul 9, 2024

Blocked by #151233.

Kibana version:
main

Describe the bug:
In dashboard panels where the preview exists (ES|QL for example), the user can perform the panel actions while it is still in the create panel flow which in turn could results in some unexpected behaviour. For Instance; one can delete the panel being added, which leaves the user in an orphaned configuration flyout with no panel on which the configuration is being made to.

Steps to reproduce:

  1. Navigate to dashboard app, click the add panel button, select for example the ES|QL visualisation option.
  2. On being presented the configuration flow for this panel, click the panel action hamburger menu, and delete the panel that was just added
  3. One would be left with an orphaned configuration flyout

Expected behavior:

  • Deleting the panel through panel action button should close the configuration flyout.

Screenshots (if relevant):

bug-panels-with-preview.mov
@eokoneyo eokoneyo added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Project:Dashboard Usability Related to the Dashboard Usability initiative labels Jul 9, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jul 9, 2024
@cqliu1 cqliu1 added the good first issue low hanging fruit label Jul 19, 2024
@cqliu1
Copy link
Contributor

cqliu1 commented Jul 25, 2024

This should come after #151233 is merged. We may also want to consider disabling all of the actions besides maximize/minimize.

@andreadelrio What do you think?

@andreadelrio
Copy link
Contributor

andreadelrio commented Jul 26, 2024

This should come after #151233 is merged. We may also want to consider disabling all of the actions besides maximize/minimize.

@andreadelrio What do you think?

@cqliu1 I'm thinking we implement something like this

CleanShot 2024-07-25 at 15 03 07

Where the maximize/minimize actions are the only actions available in the panel and they're visible at all times (so not a hover action). This pattern is the same that I'm proposing for the upcoming inline markdown editor (see #188910)

@vikasrajputin
Copy link

Hello @andreadelrio - Can i pick this?

@Heenawter
Copy link
Contributor

@vikasrajputin Thanks so much! This is currently blocked until #151233 is resolved, but it will be unblocked soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Dashboard Usability Related to the Dashboard Usability initiative Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

7 participants