Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLO] Use generic edit actions in the SLO Embeddables #186365

Closed
mgiota opened this issue Jun 18, 2024 · 1 comment · Fixed by #186374
Closed

[SLO] Use generic edit actions in the SLO Embeddables #186365

mgiota opened this issue Jun 18, 2024 · 1 comment · Fixed by #186374
Assignees
@mgiota
Labels
Feature:SLO Team:obs-ux-management Observability Management User Experience Team v8.15.0

Comments

@mgiota
Copy link
Contributor

mgiota commented Jun 18, 2024

🍒 Summary

Currently SLO Overview and Alerts Embeddables have separate edit actions registered to the context menu instead of using the generic embeddable edit panel action by defining onEdit, isEditable and getTypeDisplayName on the embeddable factories.

✔️ Acceptance criteria

  • Remove the embeddable specific actions in favor of the generic edit action

screenshot_2024-06-04_at_10 20 59___am

cc @cqliu1
@mgiota mgiota changed the title [SLO] Use generic edit actions for the SLO Embeddables [SLO] Use generic edit actions in the SLO Embeddables Jun 18, 2024
@mgiota mgiota self-assigned this Jun 18, 2024
@mgiota mgiota added the v8.15.0 label Jun 18, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 18, 2024
@mgiota mgiota added Team:obs-ux-management Observability Management User Experience Team and removed needs-team Issues missing a team label labels Jun 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@mgiota mgiota mentioned this issue Jun 18, 2024
Merged
mgiota added a commit that referenced this issue Jun 21, 2024
@mgiota @kibanamachine
[SLO] use generic edit actions in the SLO embeddables (#186374)
dca0ea2 
Fixes #186365

## SLO Group Overview Embeddable
- `Edit criteria` appears on top
- Edit criteria does not appear under `More` actions
- Inline Edit criteria is removed from the panel



https://github.com/elastic/kibana/assets/2852703/4b322361-08dd-4f3f-8440-2d4380efa2bd



## SLO Alerts Embeddable
- `Edit configuration` appears on top
- Edit configuration does not appear under `More` actions
- `X SLOs included` within the panel still opens the Edit configuration



https://github.com/elastic/kibana/assets/2852703/c609fa70-4c1f-4aa5-aa17-4e765456f7e6

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
bhapas pushed a commit to bhapas/kibana that referenced this issue Jun 24, 2024
@mgiota @kibanamachine @bhapas
[SLO] use generic edit actions in the SLO embeddables (elastic#186374)
5a5e057 
Fixes elastic#186365

## SLO Group Overview Embeddable
- `Edit criteria` appears on top
- Edit criteria does not appear under `More` actions
- Inline Edit criteria is removed from the panel



https://github.com/elastic/kibana/assets/2852703/4b322361-08dd-4f3f-8440-2d4380efa2bd



## SLO Alerts Embeddable
- `Edit configuration` appears on top
- Edit configuration does not appear under `More` actions
- `X SLOs included` within the panel still opens the Edit configuration



https://github.com/elastic/kibana/assets/2852703/c609fa70-4c1f-4aa5-aa17-4e765456f7e6

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgiota mgiota

Labels
Feature:SLO Team:obs-ux-management Observability Management User Experience Team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SLO] use generic edit actions in the SLO embeddables mgiota/kibana
2 participants
@mgiota @elasticmachine