Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Restore TSDB downsample tests #164410

Merged
merged 7 commits into from
Sep 8, 2023
Merged

[Lens] Restore TSDB downsample tests #164410

merged 7 commits into from
Sep 8, 2023

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Aug 22, 2023

Summary

Fixes #163971 finally.

This PR keep tracks of ES fix for the TSDB downsampling and will be ready to restore the tests once the bug has been fixed.

The issue has been fixed with elastic/elasticsearch#98840 on ES side.

Checklist

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens labels Aug 22, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #67 / lens app - group 4 lens tsdb Scenarios with changing stream type Data-stream upgraded to TSDB scenarios Dataview with an additional downsampled TSDB stream should visualize a date histogram chart for counter field

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 marked this pull request as ready for review September 8, 2023 14:18
@dej611 dej611 requested a review from a team as a code owner September 8, 2023 14:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! LGTM!

@dej611 dej611 merged commit 3aa9d7b into elastic:main Sep 8, 2023
35 checks passed
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 8, 2023
## Summary

Fixes elastic#163971 finally.

This PR keep tracks of ES fix for the TSDB downsampling and will be
ready to restore the tests once the bug has been fixed.

The issue has been fixed with
elastic/elasticsearch#98840 on ES side.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 3aa9d7b)
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 4, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@dej611 dej611 removed backport missing Added to PRs automatically when the are determined to be missing a backport. v8.10.1 labels Mar 7, 2024
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 8, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@dej611 dej611 added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.11.0
Projects
None yet
5 participants