Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KEYBOARD]: Top Nav must set focus correctly when users press Edit or Save button #114151

Closed
1Copenut opened this issue Oct 6, 2021 · 3 comments
Labels
accessibility: keyboard navigation Accessibility keyboard navigation and focus blocked impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v8.0.0 WCAG A

Comments

@1Copenut
Copy link
Contributor

1Copenut commented Oct 6, 2021

Description
Our Top Nav should be setting focus on the containing <nav> DOM element when users press the Edit button to toggle to edit mode or the Save button to return to view mode. This helps keyboard and screen reader users who are expecting focus order to be managed so that they don't have to traverse backwards to hear or access the menu options.

This issue will not be fixable without an EUI update, captured in elastic/eui#5248

Steps to reproduce

  1. Open a Kibana instance and add a sample data set
  2. Use the TAB key to navigate to the Edit button, then press ENTER
  3. Press the TAB key a few more times, and verify focus is not set on the Options button first

Screen Shot 2021-10-06 at 12 30 11 PM


kibana-dashboard-options-menu.mov

Actual Result

  • Focus is set on the body tag when I press Enter

Expected Result

  • Focus will be set on the nav element so I can press the TAB key once and focus the Options button

Related Issue

Kibana Version:
v8.0.0

OS:
MacOS Big Sur

Browser:
Chrome latest

Relevant WCAG Criteria: [Understanding Success Criterion 2.4.3: Focus Order

@1Copenut 1Copenut added Project:Accessibility WCAG A v8.0.0 needs-team Issues missing a team label accessibility: keyboard navigation Accessibility keyboard navigation and focus labels Oct 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@1Copenut 1Copenut added blocked Feature:Dashboard Dashboard related features labels Oct 6, 2021
@1Copenut 1Copenut removed Feature:Dashboard Dashboard related features needs-team Issues missing a team label labels Oct 6, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 6, 2021
@1Copenut 1Copenut changed the title (Accessibility) [KEYBOARD]: Top Nav must set focus correctly when users press Edit or Save button [KEYBOARD]: Top Nav must set focus correctly when users press Edit or Save button Oct 6, 2021
@1Copenut 1Copenut added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Oct 7, 2021
@nickpeihl nickpeihl added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Dec 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Kibana-Design)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 8, 2021
@1Copenut
Copy link
Contributor Author

I'm opting to close this issue for now. The current behavior in v8.8.0 is to move focus to a screen reader H1 just beneath the global navigation header on Edit | View change. This tests well with screen readers, so I feel we've got a good, defensible solution in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility: keyboard navigation Accessibility keyboard navigation and focus blocked impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v8.0.0 WCAG A
Projects
None yet
Development

No branches or pull requests

3 participants