Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiHeaderLinks][KEYBOARD]: HeaderLinks component needs optional ref and tabindex props to facilitate keyboard focus #5248

Closed
3 tasks
1Copenut opened this issue Oct 6, 2021 · 5 comments

Comments

@1Copenut
Copy link
Contributor

1Copenut commented Oct 6, 2021

Description
I'd like to request we add two optional props to the <HeaderLinks /> component:

  1. A ref hook of type <HTMLElement>
  2. A tabindex with default value of -1

I'm reviewing an issue in Kibana where focus is not managed properly on the dashboard views when users click the Edit/Save button to switch from View to Edit mode and back again. The larger issue is Kibana-specific, but these props will enable consumers to manage focus with custom event handlers.

Success criteria

  • The ref may only need to be added to our EuiHeaderLinksProps type
  • tabindex="-1" could be a boolean like isFocusable that sets "-1" or only if the prop is passed
  • No focus halo when the element takes focus. I'm happy to discuss this one further, because it's a gray area.
@1Copenut 1Copenut changed the title [KEYBOARD]: HeaderLinks component needs optional ref and tabindex props to facilitate keyboard focus [EuiHeaderLinks][KEYBOARD]: HeaderLinks component needs optional ref and tabindex props to facilitate keyboard focus Oct 7, 2021
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@1Copenut
Copy link
Contributor Author

1Copenut commented Apr 6, 2022

Keep open please

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

@github-actions
Copy link

❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context.

@cee-chen cee-chen closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants