Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Licensing] Add UA deprecation for xpack.xpack_main.xpack_api_polling_frequency_millis #113235

Closed
mshustov opened this issue Sep 28, 2021 · 3 comments
Closed

[Licensing] Add UA deprecation for xpack.xpack_main.xpack_api_polling_frequency_millis #113235

mshustov opened this issue Sep 28, 2021 · 3 comments
Labels
Feature:License Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc triage_needed

Comments

@mshustov
Copy link
Contributor

xpack.xpack_main.xpack_api_polling_frequency_millis is deprecated in favour of xpack.licensing.api_polling_frequency but it's not listed in Upgrade Assistant UI.
The setting's been deprecated since v7.6.0 #52994
@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc triage_needed Feature:License required-for-8.0 This work is required to be done before 8.0 lands, bc it relates to a breaking change or similar. labels Sep 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet
Copy link
Contributor

It's using a standard renameFromRoot factory

kibana/x-pack/plugins/licensing/server/licensing_config.ts

Lines 21 to 26 in 4584a8b

deprecations: ({ renameFromRoot }) => [
renameFromRoot(
'xpack.xpack_main.xpack_api_polling_frequency_millis',
'xpack.licensing.api_polling_frequency'
),
],

How come it would not be listed in UA as any other factory-built deprecations?

@mshustov
Copy link
Contributor Author

found it. closing
image

@mshustov mshustov removed the required-for-8.0 This work is required to be done before 8.0 lands, bc it relates to a breaking change or similar. label Sep 28, 2021
@lukeelmers lukeelmers mentioned this issue Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:License Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc triage_needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pgayvallet @mshustov @elasticmachine