Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken breadcrumbs in observability #102131

Closed
smith opened this issue Jun 14, 2021 · 0 comments · Fixed by #102290
Closed

Broken breadcrumbs in observability #102131

smith opened this issue Jun 14, 2021 · 0 comments · Fixed by #102290
Assignees
@smith
Labels
bug Fixes for quality problems that affect the customer experience Team:Observability Team label for Observability Team (for things that are handled across all of observability) Theme: rac label obsolete v7.14.0

Comments

@smith
Copy link
Contributor

smith commented Jun 14, 2021

Current behavior:

  • Navigate to Observability Cases
  • Click the "Create new case" button
  • The breadcrumb now says "Kibana"

Expected behavior:

  • The breadcrumb says "Observability > Cases > Create"

This is most probably caused by the fact that the Observability plugin is handling breadcrumbs in two places:

On the pages where both are used I think the problem is related to the fact that core.chrome.setBreadcrumbs is being called twice, though no console errors related to this are logged so I'm not sure.
@smith smith added bug Fixes for quality problems that affect the customer experience Team:Observability Team label for Observability Team (for things that are handled across all of observability) v7.14.0 Theme: rac label obsolete labels Jun 14, 2021
@jonathan-buttner jonathan-buttner mentioned this issue Jun 14, 2021
Merged
@smith smith self-assigned this Jun 16, 2021
smith added a commit to smith/kibana that referenced this issue Jun 16, 2021
@smith
Refactor observability plugin breadcrumbs
394b994 
Previously the observability plugin set the page title and breadcrumbs in the main app rendering component based on the `breadcrumb` property of the current route.

In addition, there's a `useBreadcrumb` hook used by the UX app, exploratory view, and cases.

The conflict between these was creating situations where neither would work and the breadcrumbs would just show "Kibana".

Remove the breadcrumb properties from the routes and the main app breadcrumb handling and just use `useBreadcrumb` on all pages.

Fixes elastic#102131.
@smith smith mentioned this issue Jun 16, 2021
Merged
smith added a commit that referenced this issue Jun 17, 2021
@smith
Refactor observability plugin breadcrumbs (#102290)
6113520 
Previously the observability plugin set the page title and breadcrumbs in the main app rendering component based on the `breadcrumb` property of the current route.

In addition, there's a `useBreadcrumb` hook used by the UX app, exploratory view, and cases.

The conflict between these was creating situations where neither would work and the breadcrumbs would just show "Kibana".

Remove the breadcrumb properties from the routes and the main app breadcrumb handling and just use `useBreadcrumb` on all pages.

Fixes #102131.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jun 17, 2021
@smith @kibanamachine
Refactor observability plugin breadcrumbs (elastic#102290)
4437857 
Previously the observability plugin set the page title and breadcrumbs in the main app rendering component based on the `breadcrumb` property of the current route.

In addition, there's a `useBreadcrumb` hook used by the UX app, exploratory view, and cases.

The conflict between these was creating situations where neither would work and the breadcrumbs would just show "Kibana".

Remove the breadcrumb properties from the routes and the main app breadcrumb handling and just use `useBreadcrumb` on all pages.

Fixes elastic#102131.
kibanamachine added a commit that referenced this issue Jun 17, 2021
@kibanamachine @smith
Refactor observability plugin breadcrumbs (#102290) (#102447)
9836afd 
Previously the observability plugin set the page title and breadcrumbs in the main app rendering component based on the `breadcrumb` property of the current route.

In addition, there's a `useBreadcrumb` hook used by the UX app, exploratory view, and cases.

The conflict between these was creating situations where neither would work and the breadcrumbs would just show "Kibana".

Remove the breadcrumb properties from the routes and the main app breadcrumb handling and just use `useBreadcrumb` on all pages.

Fixes #102131.

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
majagrubic pushed a commit to majagrubic/kibana that referenced this issue Jun 18, 2021
@smith
Refactor observability plugin breadcrumbs (elastic#102290)
5d60be0 
Previously the observability plugin set the page title and breadcrumbs in the main app rendering component based on the `breadcrumb` property of the current route.

In addition, there's a `useBreadcrumb` hook used by the UX app, exploratory view, and cases.

The conflict between these was creating situations where neither would work and the breadcrumbs would just show "Kibana".

Remove the breadcrumb properties from the routes and the main app breadcrumb handling and just use `useBreadcrumb` on all pages.

Fixes elastic#102131.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smith smith

Labels
bug Fixes for quality problems that affect the customer experience Team:Observability Team label for Observability Team (for things that are handled across all of observability) Theme: rac label obsolete v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor observability plugin breadcrumbs smith/kibana
1 participant
@smith