-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken breadcrumbs in observability #102131
Labels
bug
Fixes for quality problems that affect the customer experience
Team:Observability
Team label for Observability Team (for things that are handled across all of observability)
Theme: rac
label obsolete
v7.14.0
Comments
smith
added
bug
Fixes for quality problems that affect the customer experience
Team:Observability
Team label for Observability Team (for things that are handled across all of observability)
v7.14.0
Theme: rac
label obsolete
labels
Jun 14, 2021
Merged
smith
added a commit
to smith/kibana
that referenced
this issue
Jun 16, 2021
Previously the observability plugin set the page title and breadcrumbs in the main app rendering component based on the `breadcrumb` property of the current route. In addition, there's a `useBreadcrumb` hook used by the UX app, exploratory view, and cases. The conflict between these was creating situations where neither would work and the breadcrumbs would just show "Kibana". Remove the breadcrumb properties from the routes and the main app breadcrumb handling and just use `useBreadcrumb` on all pages. Fixes elastic#102131.
smith
added a commit
that referenced
this issue
Jun 17, 2021
Previously the observability plugin set the page title and breadcrumbs in the main app rendering component based on the `breadcrumb` property of the current route. In addition, there's a `useBreadcrumb` hook used by the UX app, exploratory view, and cases. The conflict between these was creating situations where neither would work and the breadcrumbs would just show "Kibana". Remove the breadcrumb properties from the routes and the main app breadcrumb handling and just use `useBreadcrumb` on all pages. Fixes #102131.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Jun 17, 2021
Previously the observability plugin set the page title and breadcrumbs in the main app rendering component based on the `breadcrumb` property of the current route. In addition, there's a `useBreadcrumb` hook used by the UX app, exploratory view, and cases. The conflict between these was creating situations where neither would work and the breadcrumbs would just show "Kibana". Remove the breadcrumb properties from the routes and the main app breadcrumb handling and just use `useBreadcrumb` on all pages. Fixes elastic#102131.
kibanamachine
added a commit
that referenced
this issue
Jun 17, 2021
Previously the observability plugin set the page title and breadcrumbs in the main app rendering component based on the `breadcrumb` property of the current route. In addition, there's a `useBreadcrumb` hook used by the UX app, exploratory view, and cases. The conflict between these was creating situations where neither would work and the breadcrumbs would just show "Kibana". Remove the breadcrumb properties from the routes and the main app breadcrumb handling and just use `useBreadcrumb` on all pages. Fixes #102131. Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this issue
Jun 18, 2021
Previously the observability plugin set the page title and breadcrumbs in the main app rendering component based on the `breadcrumb` property of the current route. In addition, there's a `useBreadcrumb` hook used by the UX app, exploratory view, and cases. The conflict between these was creating situations where neither would work and the breadcrumbs would just show "Kibana". Remove the breadcrumb properties from the routes and the main app breadcrumb handling and just use `useBreadcrumb` on all pages. Fixes elastic#102131.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Team:Observability
Team label for Observability Team (for things that are handled across all of observability)
Theme: rac
label obsolete
v7.14.0
Current behavior:
Expected behavior:
This is most probably caused by the fact that the Observability plugin is handling breadcrumbs in two places:
useBreadcrumbs
hook (used by Cases and Exploratory view)On the pages where both are used I think the problem is related to the fact that
core.chrome.setBreadcrumbs
is being called twice, though no console errors related to this are logged so I'm not sure.The text was updated successfully, but these errors were encountered: