[TSVB] Fix per-request caching of index patterns (#97043)

src/plugins/vis_type_timeseries/common/__mocks__/index_patterns_utils.ts

@@ -0,0 +1,18 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+const mock = jest.requireActual('../index_patterns_utils');
+
+jest.spyOn(mock, 'fetchIndexPattern');
+
+export const {
+  isStringTypeIndexPattern,
+  getIndexPatternKey,
+  extractIndexPatternValues,
+  fetchIndexPattern,
+} = mock;

src/plugins/vis_type_timeseries/server/lib/search_strategies/lib/cached_index_pattern_fetcher.test.ts

@@ -7,11 +7,14 @@
  */
 
 import { IndexPattern, IndexPatternsService } from 'src/plugins/data/server';
+import { fetchIndexPattern } from '../../../../common/index_patterns_utils';
 import {
   getCachedIndexPatternFetcher,
   CachedIndexPatternFetcher,
 } from './cached_index_pattern_fetcher';
 
+jest.mock('../../../../common/index_patterns_utils');
+
 describe('CachedIndexPatternFetcher', () => {
   let mockedIndices: IndexPattern[] | [];
   let cachedIndexPatternFetcher: CachedIndexPatternFetcher;
@@ -25,6 +28,8 @@ describe('CachedIndexPatternFetcher', () => {
       find: jest.fn(() => Promise.resolve(mockedIndices || [])),
     } as unknown) as IndexPatternsService;
 
+    (fetchIndexPattern as jest.Mock).mockClear();
+
     cachedIndexPatternFetcher = getCachedIndexPatternFetcher(indexPatternsService);
   });
 
@@ -52,6 +57,14 @@ describe('CachedIndexPatternFetcher', () => {
         }
       `);
     });
+
+    test('should cache once', async () => {
+      await cachedIndexPatternFetcher('indexTitle');
+      await cachedIndexPatternFetcher('indexTitle');
+      await cachedIndexPatternFetcher('indexTitle');
+
+      expect(fetchIndexPattern as jest.Mock).toHaveBeenCalledTimes(1);
+    });
   });
 
   describe('object-based index', () => {
@@ -86,5 +99,20 @@ describe('CachedIndexPatternFetcher', () => {
         }
       `);
     });
+
+    test('should cache once', async () => {
+      mockedIndices = [
+        {
+          id: 'indexId',
+          title: 'indexTitle',
+        },
+      ] as IndexPattern[];
+
+      await cachedIndexPatternFetcher({ id: 'indexId' });
+      await cachedIndexPatternFetcher({ id: 'indexId' });
+      await cachedIndexPatternFetcher({ id: 'indexId' });
+
+      expect(fetchIndexPattern as jest.Mock).toHaveBeenCalledTimes(1);
+    });
   });
 });

src/plugins/vis_type_timeseries/server/lib/search_strategies/lib/cached_index_pattern_fetcher.ts

@@ -23,7 +23,7 @@ export const getCachedIndexPatternFetcher = (indexPatternsService: IndexPatterns
 
     const fetchedIndex = fetchIndexPattern(indexPatternValue, indexPatternsService);
 
-    cache.set(indexPatternValue, fetchedIndex);
+    cache.set(key, fetchedIndex);
 
     return fetchedIndex;
   };