Address Andrea's comments

elastic · Jul 29, 2024 · e5dc627 · e5dc627
1 parent 40e282b
commit e5dc627
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/src/plugins/esql_datagrid/public/data_grid.tsx b/src/plugins/esql_datagrid/public/data_grid.tsx
@@ -159,11 +159,12 @@ const DataGrid: React.FC<ESQLDataGridProps> = (props) => {
             <EuiLink
               href={discoverLink}
               target="_blank"
-              color="text"
+              color="primary"
               css={css`
                 display: flex;
                 align-items: center;
               `}
+              external={false}
             >
               <EuiIcon
                 type="discoverApp"
@@ -174,7 +175,7 @@ const DataGrid: React.FC<ESQLDataGridProps> = (props) => {
               />
               <EuiText size="xs">
                 {i18n.translate('esqlDataGrid.openInDiscoverLabel', {
-                  defaultMessage: 'Open in Discover.',
+                  defaultMessage: 'Open in Discover',
                 })}
               </EuiText>
             </EuiLink>

diff --git a/x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/lens_configuration_flyout.tsx b/x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/lens_configuration_flyout.tsx
@@ -517,6 +517,7 @@ export function LensEditConfigurationFlyout({
                   flex: ${isESQLResultsAccordionOpen ? 1 : 'none'};
                 }
                 padding: 0 ${euiThemeVars.euiSize};
+                border-bottom: ${euiThemeVars.euiBorderThin};
               `}
             >
               <EuiAccordion

diff --git a/x-pack/plugins/lens/public/trigger_actions/open_lens_config/edit_action_helpers.ts b/x-pack/plugins/lens/public/trigger_actions/open_lens_config/edit_action_helpers.ts
@@ -6,6 +6,8 @@
  */
 import React from 'react';
 import './helpers.scss';
+import { css } from '@emotion/react';
+import { euiThemeVars } from '@kbn/ui-theme';
 import { toMountPoint } from '@kbn/react-kibana-mount';
 import { tracksOverlays } from '@kbn/presentation-containers';
 import type { IEmbeddable } from '@kbn/embeddable-plugin/public';
@@ -72,6 +74,10 @@ const openInlineLensConfigEditor = (
         overlayRef.close();
       },
       outsideClickCloses: true,
+      css: css`
+        max-width: calc(${euiThemeVars.euiSizeXXL} * 20);
+        min-width: calc(${euiThemeVars.euiSizeXXL} * 10);
+      `,
     }
   );