cleanup 2

elastic · Nov 22, 2021 · de5c783 · de5c783
1 parent d463edf
commit de5c783
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/packages/kbn-apm-config-loader/src/init_apm.ts b/packages/kbn-apm-config-loader/src/init_apm.ts
@@ -17,9 +17,6 @@ export const initApm = (
   const apmConfigLoader = loadConfiguration(argv, rootDir, isDistributable);
   const apmConfig = apmConfigLoader.getConfig(serviceName);
 
-  // eslint-disable-next-line no-console
-  console.log('>>> apmConfig', apmConfig);
-
   // we want to only load the module when effectively used
   // eslint-disable-next-line @typescript-eslint/no-var-requires
   const apm = require('elastic-apm-node');

diff --git a/src/core/server/http/http_server.ts b/src/core/server/http/http_server.ts
@@ -346,6 +346,8 @@ export class HttpServer {
         ...(request.app ?? {}),
         requestId,
         requestUuid: uuid.v4(),
+        // Kibana stores trace.id until https://github.com/elastic/apm-agent-nodejs/issues/2353 is resolved
+        // The current implementation of the APM agent ends a request transaction before "response" log is emitted.
         traceId: agent.currentTraceIds['trace.id'],
       } as KibanaRequestState;
       return responseToolkit.continue;