Some clarity, cleanup, and snapshot updates

packages/kbn-test/src/functional_test_runner/lib/mocha/decorate_mocha_ui.js

@@ -22,7 +22,7 @@ import { createAssignmentProxy } from './assignment_proxy';
 import { wrapFunction } from './wrap_function';
 import { wrapRunnableArgs } from './wrap_runnable_args';
 
-export function decorateMochaUi(lifecycle, context, config) {
+export function decorateMochaUi(lifecycle, context) {
   // incremented at the start of each suite, decremented after
   // so that in each non-suite call we can know if we are within
   // a suite, or that when a suite is defined it is within a suite
@@ -66,11 +66,9 @@ export function decorateMochaUi(lifecycle, context, config) {
             this._tags = [].concat(this._tags || [], tags);
           };
 
-          const filePath = this.file.replace(REPO_ROOT + sep, '');
-          this.tags(filePath);
-          this.suiteTag = filePath; // The tag that uniquely targets this suite/file
-
-          this.ftrConfig = config;
+          const relativeFilePath = this.file.replace(REPO_ROOT + sep, '');
+          this.tags(relativeFilePath);
+          this.suiteTag = relativeFilePath; // The tag that uniquely targets this suite/file
 
           provider.call(this);
 

packages/kbn-test/src/functional_test_runner/lib/mocha/setup_mocha.js

@@ -58,6 +58,8 @@ export async function setupMocha(lifecycle, log, config, providers) {
     updateBaselines: config.get('updateBaselines'),
   });
 
+  // Each suite has a tag that is the path relative to the root of the repo
+  // So we just need to take input paths, make them relative to the root, and use them as tags
   filterSuitesByTags({
     log,
     mocha,