Skip to content

Commit

Permalink
fixing types and ml icon order
Browse files Browse the repository at this point in the history
  • Loading branch information
jgowdyelastic committed Mar 13, 2020
1 parent fa1f2d8 commit c53830d
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 19 deletions.
2 changes: 1 addition & 1 deletion x-pack/plugins/ml/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ export class MlPlugin implements Plugin<Setup, Start> {
title: i18n.translate('xpack.ml.plugin.title', {
defaultMessage: 'Machine Learning',
}),
order: 30,
euiIconType: PLUGIN_ICON,
order: 8001,
appRoute: '/app/ml',
mount: async (params: AppMountParameters) => {
const [coreStart, pluginsStart] = await core.getStartServices();
Expand Down
34 changes: 17 additions & 17 deletions x-pack/plugins/ml/server/lib/ml_telemetry/ml_telemetry.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
* you may not use this file except in compliance with the Elastic License.
*/

import {
// createMlTelemetry,
// incrementFileDataVisualizerIndexCreationCount,
// ML_TELEMETRY_DOC_ID,
MlTelemetry,
// storeMlTelemetry,
} from './ml_telemetry';
// import {
// createMlTelemetry,
// incrementFileDataVisualizerIndexCreationCount,
// ML_TELEMETRY_DOC_ID,
// MlTelemetry,
// storeMlTelemetry,
// } from './ml_telemetry';

describe('ml_telemetry', () => {
describe('createMlTelemetry', () => {
Expand All @@ -25,17 +25,17 @@ describe('ml_telemetry', () => {
});

describe('storeMlTelemetry', () => {
let mlTelemetry: MlTelemetry;
let internalRepository: any;
// let mlTelemetry: MlTelemetry;
// let internalRepository: any;

beforeEach(() => {
internalRepository = { create: jest.fn(), get: jest.fn() };
mlTelemetry = {
file_data_visualizer: {
index_creation_count: 1,
},
};
});
// beforeEach(() => {
// internalRepository = { create: jest.fn(), get: jest.fn() };
// mlTelemetry = {
// file_data_visualizer: {
// index_creation_count: 1,
// },
// };
// });

it('should call internalRepository create with the given MlTelemetry object', () => {
// storeMlTelemetry(internalRepository, mlTelemetry);
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/ml/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"extends": "../../../tsconfig.json"
"extends": "../../tsconfig.json"
}

0 comments on commit c53830d

Please sign in to comment.