Hardcoding the saved object types

elastic · Apr 19, 2021 · bac104e · bac104e
1 parent 80b435d
commit bac104e
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 2 deletions.
diff --git a/x-pack/plugins/cases/common/constants.ts b/x-pack/plugins/cases/common/constants.ts
@@ -14,6 +14,9 @@ export const CASE_USER_ACTION_SAVED_OBJECT = 'cases-user-actions';
 export const CASE_COMMENT_SAVED_OBJECT = 'cases-comments';
 export const CASE_CONFIGURE_SAVED_OBJECT = 'cases-configure';
 
+/**
+ * If more values are added here please also add them here: x-pack/test/case_api_integration/common/fixtures/plugins
+ */
 export const SAVED_OBJECT_TYPES = [
   CASE_SAVED_OBJECT,
   CASE_CONNECTOR_MAPPINGS_SAVED_OBJECT,

diff --git a/x-pack/test/case_api_integration/common/fixtures/plugins/observability/server/plugin.ts b/x-pack/test/case_api_integration/common/fixtures/plugins/observability/server/plugin.ts
@@ -10,7 +10,6 @@ import { Plugin, CoreSetup } from 'kibana/server';
 import { PluginSetupContract as FeaturesPluginSetup } from '../../../../../../../plugins/features/server';
 import { SpacesPluginStart } from '../../../../../../../plugins/spaces/server';
 import { SecurityPluginStart } from '../../../../../../../plugins/security/server';
-import { SAVED_OBJECT_TYPES as casesSavedObjectTypes } from '../../../../../../../plugins/cases/common/constants';
 
 export interface FixtureSetupDeps {
   features: FeaturesPluginSetup;
@@ -21,6 +20,19 @@ export interface FixtureStartDeps {
   spaces?: SpacesPluginStart;
 }
 
+/**
+ * These are a copy of the values here: x-pack/plugins/cases/common/constants.ts because when the plugin attempts to
+ * import them from the constants.ts file it gets an error.
+ */
+const casesSavedObjectTypes = [
+  'cases',
+  'cases-connector-mappings',
+  'cases-sub-case',
+  'cases-user-actions',
+  'cases-comments',
+  'cases-configure',
+];
+
 export class FixturePlugin implements Plugin<void, void, FixtureSetupDeps, FixtureStartDeps> {
   public setup(core: CoreSetup<FixtureStartDeps>, deps: FixtureSetupDeps) {
     const { features } = deps;

diff --git a/x-pack/test/case_api_integration/common/fixtures/plugins/security_solution/server/plugin.ts b/x-pack/test/case_api_integration/common/fixtures/plugins/security_solution/server/plugin.ts
@@ -10,7 +10,6 @@ import { Plugin, CoreSetup } from 'kibana/server';
 import { PluginSetupContract as FeaturesPluginSetup } from '../../../../../../../plugins/features/server';
 import { SpacesPluginStart } from '../../../../../../../plugins/spaces/server';
 import { SecurityPluginStart } from '../../../../../../../plugins/security/server';
-import { SAVED_OBJECT_TYPES as casesSavedObjectTypes } from '../../../../../../../plugins/cases/common/constants';
 
 export interface FixtureSetupDeps {
   features: FeaturesPluginSetup;
@@ -21,6 +20,18 @@ export interface FixtureStartDeps {
   spaces?: SpacesPluginStart;
 }
 
+/**
+ * These are a copy of the values here: x-pack/plugins/cases/common/constants.ts because when the plugin attempts to
+ * import them from the constants.ts file it gets an error.
+ */
+const casesSavedObjectTypes = [
+  'cases',
+  'cases-connector-mappings',
+  'cases-sub-case',
+  'cases-user-actions',
+  'cases-comments',
+  'cases-configure',
+];
 export class FixturePlugin implements Plugin<void, void, FixtureSetupDeps, FixtureStartDeps> {
   public setup(core: CoreSetup<FixtureStartDeps>, deps: FixtureSetupDeps) {
     const { features } = deps;