Skip to content

Commit

Permalink
[kbn/pm] log levels (#68203)
Browse files Browse the repository at this point in the history
Co-authored-by: spalger <spalger@users.noreply.github.com>
  • Loading branch information
Spencer and spalger authored Jun 8, 2020
1 parent b39234c commit ab226f0
Show file tree
Hide file tree
Showing 25 changed files with 50,209 additions and 50,593 deletions.
2 changes: 1 addition & 1 deletion packages/kbn-dev-utils/src/tooling_log/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@

export { ToolingLog } from './tooling_log';
export { ToolingLogTextWriter, ToolingLogTextWriterConfig } from './tooling_log_text_writer';
export { pickLevelFromFlags, parseLogLevel, LogLevel } from './log_levels';
export { pickLevelFromFlags, parseLogLevel, LogLevel, ParsedLogLevel } from './log_levels';
export { ToolingLogCollectingWriter } from './tooling_log_collecting_writer';
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,14 @@
*/

import { ToolingLogTextWriter } from './tooling_log_text_writer';
import { LogLevel } from './log_levels';

export class ToolingLogCollectingWriter extends ToolingLogTextWriter {
messages: string[] = [];

constructor() {
constructor(level: LogLevel = 'verbose') {
super({
level: 'verbose',
level,
writeTo: {
write: (msg) => {
// trim trailing new line
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export interface ToolingLogTextWriterConfig {

function shouldWriteType(level: ParsedLogLevel, type: MessageTypes) {
if (type === 'write') {
return true;
return level.name !== 'silent';
}

return Boolean(level.flags[type === 'success' ? 'info' : type]);
Expand Down
Loading

0 comments on commit ab226f0

Please sign in to comment.