[Security Solution][Data Views] - Update bulk actions data views inde…

…x param to be snake_case (#138429) (#138443)

## Summary

Overlooked a param name - should be snake case per our APIs. `overwriteDataViews` --> `overwrite_data_views`

(cherry picked from commit 6da6f18)

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>

x-pack/plugins/security_solution/common/detection_engine/schemas/common/schemas.ts

@@ -401,7 +401,7 @@ const bulkActionEditPayloadIndexPatterns = t.intersection([
     ]),
     value: index,
   }),
-  t.exact(t.partial({ overwriteDataViews: t.boolean })),
+  t.exact(t.partial({ overwrite_data_views: t.boolean })),
 ]);
 
 export type BulkActionEditPayloadIndexPatterns = t.TypeOf<

x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/all/bulk_actions/forms/index_patterns_form.tsx

@@ -118,7 +118,7 @@ const IndexPatternsFormComponent = ({
     const payload = {
       value: data.index,
       type: data.overwrite ? BulkActionEditType.set_index_patterns : editAction,
-      overwriteDataViews: data.overwriteDataViews,
+      overwrite_data_views: data.overwriteDataViews,
     };
 
     onConfirm(payload);

x-pack/plugins/security_solution/server/lib/detection_engine/rules/bulk_actions/rule_params_modifier.test.ts

@@ -98,28 +98,28 @@ describe('ruleParamsModifier', () => {
       expect(editedRuleParams).toHaveProperty('index', ['index']);
     });
 
-    test('should set dataViewId to undefined if overwriteDataViews=true on set_index_patterns action', () => {
+    test('should set dataViewId to undefined if overwrite_data_views=true on set_index_patterns action', () => {
       const editedRuleParams = ruleParamsModifier(
         { dataViewId: 'test-data-view', index: ['test-*'] } as RuleAlertType['params'],
         [
           {
             type: BulkActionEditType.set_index_patterns,
             value: ['index'],
-            overwriteDataViews: true,
+            overwrite_data_views: true,
           },
         ]
       );
       expect(editedRuleParams).toHaveProperty('dataViewId', undefined);
     });
 
-    test('should set dataViewId to undefined if overwriteDataViews=true on add_index_patterns action', () => {
+    test('should set dataViewId to undefined if overwrite_data_views=true on add_index_patterns action', () => {
       const editedRuleParams = ruleParamsModifier(
         { dataViewId: 'test-data-view', index: ['test-*'] } as RuleAlertType['params'],
         [
           {
             type: BulkActionEditType.add_index_patterns,
             value: ['index'],
-            overwriteDataViews: true,
+            overwrite_data_views: true,
           },
         ]
       );

x-pack/plugins/security_solution/server/lib/detection_engine/rules/bulk_actions/rule_params_modifier.ts

@@ -35,7 +35,7 @@ const applyBulkActionEditToRuleParams = (
         "Index patterns can't be added. Machine learning rule doesn't have index patterns property"
       );
 
-      if (action.overwriteDataViews) {
+      if (action.overwrite_data_views) {
         ruleParams.dataViewId = undefined;
       }
 
@@ -59,7 +59,7 @@ const applyBulkActionEditToRuleParams = (
         "Index patterns can't be overwritten. Machine learning rule doesn't have index patterns property"
       );
 
-      if (action.overwriteDataViews) {
+      if (action.overwrite_data_views) {
         ruleParams.dataViewId = undefined;
       }
 

x-pack/test/detection_engine_api_integration/security_and_spaces/group1/perform_bulk_action.ts

@@ -580,7 +580,7 @@ export default ({ getService }: FtrProviderContext): void => {
               {
                 type: BulkActionEditType.add_index_patterns,
                 value: ['initial-index-*'],
-                overwriteDataViews: true,
+                overwrite_data_views: true,
               },
             ],
           })