Skip to content

Commit

Permalink
unskip maps functional tests
Browse files Browse the repository at this point in the history
  • Loading branch information
rashmivkulkarni committed Feb 3, 2021
1 parent baf3605 commit 43e3196
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 10 deletions.
8 changes: 6 additions & 2 deletions x-pack/test/functional/apps/maps/layer_errors.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ export default function ({ getPageObjects }) {

it('should diplay error message in layer panel', async () => {
const errorMsg = await PageObjects.maps.getLayerErrorText(LAYER_NAME);
expect(errorMsg).to.contain(MISSING_EMS_ID);
expect(errorMsg).to.equal(
`Unable to find EMS vector shapes for id: ${MISSING_EMS_ID}. Kibana is unable to access Elastic Maps Service. Contact your systemadministrator.`
);
});

it('should allow deletion of layer', async () => {
Expand All @@ -86,7 +88,9 @@ export default function ({ getPageObjects }) {

it('should diplay error message in layer panel', async () => {
const errorMsg = await PageObjects.maps.getLayerErrorText(LAYER_NAME);
expect(errorMsg).to.contain(MISSING_EMS_ID);
expect(errorMsg).to.equal(
`Unable to find EMS tile configuration for id: ${MISSING_EMS_ID}. Kibana is unable to access Elastic Maps Service. Contact your systemadministrator.`
);
});

it('should allow deletion of layer', async () => {
Expand Down
10 changes: 2 additions & 8 deletions x-pack/test/functional/apps/maps/sample_data.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ export default function ({ getPageObjects, getService, updateBaselines }) {
const PageObjects = getPageObjects(['common', 'maps', 'header', 'home', 'timePicker']);
const screenshot = getService('screenshots');

// FLAKY: https://github.com/elastic/kibana/issues/38137
describe('maps loaded from sample data', () => {
// Sample data is shifted to be relative to current time
// This means that a static timerange will return different documents
Expand All @@ -21,13 +20,9 @@ export default function ({ getPageObjects, getService, updateBaselines }) {
past.setMonth(past.getMonth() - 6);
const future = new Date();
future.setMonth(future.getMonth() + 6);
await PageObjects.maps.setAbsoluteRange(
PageObjects.timePicker.formatDateToAbsoluteTimeString(past),
PageObjects.timePicker.formatDateToAbsoluteTimeString(future)
);
await PageObjects.maps.setAbsoluteRange(past.toISOString(), future.toISOString());
}

// Skipped because EMS vectors are not accessible in CI
describe('ecommerce', () => {
before(async () => {
await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', {
Expand Down Expand Up @@ -59,7 +54,7 @@ export default function ({ getPageObjects, getService, updateBaselines }) {
'ecommerce_map',
updateBaselines
);
expect(percentDifference).to.be.lessThan(0.05);
expect(percentDifference).to.be.lessThan(0.06);
});
});

Expand Down Expand Up @@ -94,7 +89,6 @@ export default function ({ getPageObjects, getService, updateBaselines }) {
});
});

// Skipped because EMS vectors are not accessible in CI
describe('web logs', () => {
before(async () => {
await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', {
Expand Down

0 comments on commit 43e3196

Please sign in to comment.