old share panel removal

elastic · Apr 1, 2024 · 1f2ad7d · 1f2ad7d
1 parent cd34f52
commit 1f2ad7d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/src/plugins/share/public/components/share_tabs.tsx b/src/plugins/share/public/components/share_tabs.tsx
@@ -30,7 +30,7 @@ export const ShareMenuTabs = () => {
 
   const { allowEmbed, objectType, onClose, shareMenuItems } = shareContext;
 
-  const tabs = [linkTab, allowEmbed ? embedTab : null].filter(Boolean);
+  const tabs = [linkTab];
   if (shareMenuItems) {
     shareMenuItems
       // need to filter out the null shareMenuItem from Lens and just use the reporting image modal that includes CSV for Lens
@@ -45,6 +45,8 @@ export const ShareMenuTabs = () => {
       });
   }
 
+  if (allowEmbed) tabs.push(embedTab);
+
   return (
     <TabbedModal
       tabs={tabs}

diff --git a/x-pack/test/functional/apps/canvas/reports.ts b/x-pack/test/functional/apps/canvas/reports.ts
@@ -67,7 +67,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
           await this.clickShareTopNavButton();
         }
         const menuPanel = await this.find.byCssSelector('div.euiContextMenuPanel');
-        await this.testSubjects.click(`sharePanel-PDFReports`);
+        await this.testSubjects.click(`Export`);
         await this.testSubjects.waitForDeleted(menuPanel);
 
         await PageObjects.reporting.clickGenerateReportButton();

diff --git a/x-pack/test/functional/apps/discover/feature_controls/discover_security.ts b/x-pack/test/functional/apps/discover/feature_controls/discover_security.ts
@@ -121,7 +121,7 @@ export default function (ctx: FtrProviderContext) {
 
       it('shows CSV reports', async () => {
         await PageObjects.share.clickShareTopNavButton();
-        await testSubjects.existOrFail('sharePanel-CSVReports');
+        await testSubjects.existOrFail('Export');
         await PageObjects.share.clickShareTopNavButton();
       });
 

diff --git a/x-pack/test/reporting_functional/services/scenarios.ts b/x-pack/test/reporting_functional/services/scenarios.ts
@@ -114,7 +114,7 @@ export function createScenarios(
   };
   const tryDiscoverCsvNotAvailable = async () => {
     await PageObjects.share.clickShareTopNavButton();
-    await testSubjects.missingOrFail('sharePanel-CSVReports');
+    await testSubjects.missingOrFail('Export');
   };
   const tryDiscoverCsvSuccess = async () => {
     await PageObjects.reporting.openExportTab();
@@ -128,7 +128,7 @@ export function createScenarios(
   };
   const tryGeneratePdfNotAvailable = async () => {
     PageObjects.share.clickShareTopNavButton();
-    await testSubjects.missingOrFail(`sharePanel-PDFReports`);
+    await testSubjects.missingOrFail(`Export`);
   };
   const tryGeneratePdfSuccess = async () => {
     await PageObjects.reporting.openExportTab();
@@ -141,7 +141,7 @@ export function createScenarios(
   };
   const tryReportsNotAvailable = async () => {
     await PageObjects.share.clickShareTopNavButton();
-    await testSubjects.missingOrFail('sharePanel-Reports');
+    await testSubjects.missingOrFail('Export');
   };
 
   return {