Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][HAProxy] Migrate visualizations to lens #8375

Merged

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Nov 2, 2023

What does this PR do?

  • Migrate stat data-stream visualizations to lens for HAProxy integration package

  • Statistics for HAProxy Lens migration:

HAProxy Dashboards Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics HAProxy] HTTP backend 0 8 8 0
[Metrics HAProxy] Overview 0 4 4 0
[Metrics HAProxy] Frontend 0 2 2 0
[Metrics HAProxy] HTTP frontend 0 3 3 0
[Metrics HAProxy] HTTP server 0 6 6 0
[Metrics HAProxy] Backend 0 6 6 0
  0 29 29 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.8.0 itself.

Related issues

Screenshots

Before Migration Screenshots:

HTTP Backend
image

Overview
image

HTTP Server
image

Backend
image

Frontend
image

HTTP Frontend
image

@kush-elastic kush-elastic marked this pull request as ready for review November 2, 2023 07:14
@kush-elastic kush-elastic requested a review from a team as a code owner November 2, 2023 07:14
@kush-elastic kush-elastic mentioned this pull request Nov 2, 2023
6 tasks
@kush-elastic kush-elastic self-assigned this Nov 2, 2023
@kush-elastic kush-elastic added enhancement New feature or request Integration:haproxy HAProxy dashboard Relates to a Kibana dashboard bug, enhancement, or modification. labels Nov 2, 2023
@elasticmachine
Copy link

elasticmachine commented Nov 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-06T09:16:08.712+0000

  • Duration: 15 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 22
Skipped 0
Total 22

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 2, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 90.476% (19/21) 👎 -9.524
Lines 97.238% (176/181) 👍 3.847
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devamanv
Copy link
Contributor

devamanv commented Nov 7, 2023

@kush-elastic I see that there panels in the dashboards that end with [Metrics HAProxy], even when we already have [Metrics HAProxy] in the dashboard name like [Metrics HAProxy] Backend. I understand you are just using the names before the migration, but can we change the panel names to remove the [ ] part? Or is there a convention that we are trying to follow here?

@kush-elastic
Copy link
Collaborator Author

@kush-elastic I see that there panels in the dashboards that end with [Metrics HAProxy], even when we already have [Metrics HAProxy] in the dashboard name like [Metrics HAProxy] Backend. I understand you are just using the names before the migration, but can we change the panel names to remove the [ ] part? Or is there a convention that we are trying to follow here?

As of now, we have only migrated the panels to the lens keeping the naming of visualizations the same as before. It's a good thing to remove the repetition of suffixes in visualization titles. Once this PR is merged, I'll create a separate issue to track the removal of suffixes from all dashboards.

@kush-elastic
Copy link
Collaborator Author

@devamanv can you help me re-review this?

Copy link
Contributor

@devamanv devamanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ali786XI ali786XI merged commit e1cdf6a into elastic:main Nov 28, 2023
4 checks passed
@elasticmachine
Copy link

Package haproxy - 1.11.0 containing this change is available at https://epr.elastic.co/search?package=haproxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:haproxy HAProxy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants