Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][Redis] Migrate Logs Overview dashboard visualizations to lens in kibana 8.3.0 #5661

Merged
merged 9 commits into from
Apr 11, 2023
Merged

[O11y][Redis] Migrate Logs Overview dashboard visualizations to lens in kibana 8.3.0 #5661

merged 9 commits into from
Apr 11, 2023

Conversation

harnish-elastic
Copy link
Contributor

@harnish-elastic harnish-elastic commented Mar 23, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Redis integration package

  • Statistics for Redis Lens migration:

Redis dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Logs Redis] Overview 0 3 3 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in Kibana version 8.3.0.

Related issues

Issues identified

image

@kush-elastic kush-elastic mentioned this pull request Mar 23, 2023
Closed
7 tasks
@harnish-elastic harnish-elastic changed the title [O11y][Redis] Migrate Key Metrics dashboard visualizations to lens in kibana 8.3.0 [O11y][Redis] Migrate Logs Overview dashboard visualizations to lens in kibana 8.3.0 Mar 23, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 23, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-11T10:09:55.660+0000

  • Duration: 14 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 20
Skipped 0
Total 20

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 23, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 66.667% (14/21) ❕
Lines 94.186% (81/86) ❕
Conditionals 100.0% (0/0) 💚

@harnish-elastic harnish-elastic marked this pull request as ready for review March 23, 2023 12:40
@harnish-elastic harnish-elastic requested a review from a team as a code owner March 23, 2023 12:40
@kush-elastic kush-elastic added enhancement New feature or request Integration:redis Redis v8.3.0 Team:Service-Integrations Label for the Service Integrations team labels Mar 23, 2023
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 24, 2023
Closed
6 tasks
kush-elastic
kush-elastic approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
60cbfe7 
…into lens_migration-redis-logs_overview-8.3.0

Conflicts:
	packages/redis/changelog.yml
	packages/redis/manifest.yml
agithomas
agithomas reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not particularly happy with the pie chart colours, readability is very poor

Suggestions

  1. Increase the size of the chart
  2. Change the colour scheme so that the partitions can be distinctly seen.

@harnish-elastic
Copy link
Contributor Author

Not particularly happy with the pie chart colours, readability is very poor

Suggestions

  1. Increase the size of the chart
  2. Change the colour scheme so that the partitions can be distinctly seen.

Understood your concern. But we haven't changed the size of the pie chart and also the colors for the same.

We will update it for you in this PR and let you know.

@harnish-elastic
Copy link
Contributor Author

@agithomas Updated the PR with suggested changes. Thanks!

agithomas
agithomas reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The X and Y axis labels got interchanged.

Also, Does't the duration value auto-adjust? If so, you can remove the (microsecond) from the axis label

image

@harnish-elastic
Copy link
Contributor Author

The X and Y axis labels got interchanged.

I see the issue is regarding previous visualization. Sure we have created a bug for this change for tracking and will update the change in this PR. Thanks!

Also, Does't the duration value auto-adjust? If so, you can remove the (microsecond) from the axis label

image

Kibana hasn't any functionality to convert microsecond to sec / min / hour or any human readable state. Also we have already raised an issue for the same. elastic/kibana#153378

agithomas
agithomas approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
adf32af 
…into lens_migration-redis-logs_overview-8.3.0

Conflicts:
	packages/redis/changelog.yml
	packages/redis/manifest.yml
@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
a70beca 
…into lens_migration-redis-logs_overview-8.3.0

Conflicts:
	packages/redis/changelog.yml
	packages/redis/manifest.yml
@kush-elastic kush-elastic merged commit b277484 into elastic:main Apr 11, 2023
@elasticmachine
Copy link

Package redis - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=redis

This was referenced Apr 12, 2023
Closed
Closed
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Jul 24, 2023
Closed
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Oct 13, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kush-elastic kush-elastic kush-elastic approved these changes

@agithomas agithomas agithomas approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

Assignees

@harnish-elastic harnish-elastic

Labels
enhancement New feature or request Integration:redis Redis Team:Service-Integrations Label for the Service Integrations team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harnish-elastic @elasticmachine @kush-elastic @agithomas